Collect revision information for snap builds
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Launchpad itself |
High
|
Colin Watson | ||
| | launchpad-buildd |
High
|
Colin Watson | ||
Bug Description
It would be very useful for build.snapcraft.io to be able to determine the code revision from which a given snap build ran. There's been talk of snapcraft generating a manifest of which VCS objects it used, but I'm not sure that's scheduled any time soon and I don't want to let the perfect be the enemy of the good. Furthermore, with a small amount of work in Launchpad we can collect revision information even about builds that are still running, which would be even more helpful to BSI and can't be done using the snapcraft manifest approach.
Related branches
- William Grant: Approve (code) on 2017-05-11
-
Diff: 199 lines (+78/-5)5 files modifiedbuildsnap (+33/-5)
debian/changelog (+7/-0)
lpbuildd/slave.py (+11/-0)
lpbuildd/snap.py (+17/-0)
lpbuildd/tests/test_snap.py (+10/-0)
- William Grant: Approve (code) on 2017-04-19
-
Diff: 14 lines (+10/-0)1 file modifieddatabase/schema/patch-2209-69-8.sql (+10/-0)
- William Grant: Approve (code) on 2017-04-19
-
Diff: 254 lines (+96/-18)9 files modifiedlib/lp/buildmaster/interactor.py (+7/-10)
lib/lp/buildmaster/interfaces/buildqueue.py (+4/-1)
lib/lp/buildmaster/model/buildqueue.py (+14/-1)
lib/lp/buildmaster/tests/test_manager.py (+37/-6)
lib/lp/snappy/browser/tests/test_snapbuild.py (+10/-0)
lib/lp/snappy/interfaces/snapbuild.py (+6/-0)
lib/lp/snappy/model/snapbuild.py (+6/-0)
lib/lp/snappy/templates/snapbuild-index.pt (+3/-0)
lib/lp/snappy/tests/test_snapbuild.py (+9/-0)
| Changed in launchpad-buildd: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Colin Watson (cjwatson) |
| Changed in launchpad: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Colin Watson (cjwatson) |
| Colin Watson (cjwatson) wrote : | #2 |
Yeesh. Is that what you were asking for? I wish you'd been clearer if so, since it was ambiguous: we ultimately need both these things for build.snapcraft.io, and either one of them can reasonably be described as "revision".
| Colin Watson (cjwatson) wrote : | #3 |
Well, fortunately the other one is easier, and is now bug 1679197.
| tags: | added: api |
| Launchpad QA Bot (lpqabot) wrote : | #4 |
r13675 in db-stable (http://
| tags: | added: qa-needstesting |
| Colin Watson (cjwatson) wrote : | #5 |
2017-04-26 13:10:21,319 INFO 2209-69-8 applied 2017-04-26 in 0.0 seconds
| tags: |
added: qa-ok removed: qa-needstesting |
| Launchpad QA Bot (lpqabot) wrote : | #6 |
Fixed in stable r18366 <http://
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad-buildd: | |
| status: | In Progress → Fix Committed |
| Colin Watson (cjwatson) wrote : | #7 |
Fixed in launchpad-buildd 143.
| Changed in launchpad-buildd: | |
| status: | Fix Committed → Fix Released |
How does getting VCS metadata relate to getting the snap revision for `snap install --edge --revision`?