process-upload oopses if snap was deleted after build completed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Colin Watson |
Bug Description
OOPS-8ca2b2254372cdd43c239fea85f36938
AttributeError: 'NoneType' object has no attribute 'status'
Traceback (most recent call last):
Module lp.services.
return func(self, *args, **kw)
Module lp.services.
self.
Module lp.services.
return func(self, *args, **kw)
Module lp.services.
self.main()
Module lp.archiveuploa
processor.
Module lp.archiveuploa
handler.
Module lp.archiveuploa
if self.build.status == BuildStatus.
AttributeError: 'NoneType' object has no attribute 'status'
I suspect this happens when the snap (and hence its builds) were deleted between reaching the "Uploading build" status and process-upload running.
Related branches
- William Grant (community): Approve (code)
-
Diff: 62 lines (+30/-3)2 files modifiedlib/lp/archiveuploader/tests/test_uploadprocessor.py (+23/-1)
lib/lp/archiveuploader/uploadprocessor.py (+7/-2)
Changed in launchpad: | |
importance: | Undecided → Critical |
status: | New → Triaged |
tags: | added: lp-snappy oops soyuz-build |
Changed in launchpad: | |
assignee: | nobody → Colin Watson (cjwatson) |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Fixed in stable r18304 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 18304>.