GitHub external bug tracker fails to authenticate rate limit checks
Bug #1650134 reported by
William Grant
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
William Grant | ||
Bug Description
The GitHub ExternalBugTracker doesn't pass its token down to GitHubRateLimit, so GitHubRateLimit makes an unauthenticated rate limit query and erroneously limits checkwatches to anonymous limits. The requests that matter are correctly authenticated, but they are stopped by the unauthenticated rate limit check.
Related branches
lp:~wgrant/launchpad/gh-rate-limit-auth
- Colin Watson (community): Approve
-
Diff: 113 lines (+52/-9)2 files modifiedlib/lp/bugs/externalbugtracker/github.py (+18/-9)
lib/lp/bugs/externalbugtracker/tests/test_github.py (+34/-0)
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r18295 <http://