publish-ftpmaster allows its publish-distro calls to be interrupted by cron-control
Bug #1647478 reported by
Colin Watson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
During fastdowntime upgrades, if things happen at just the wrong times, it's possible for the in-process publish-distro calls made by publish-ftpmaster to call sys.exit(0) because the cron-control DEFAULT section has been switched to disabled. This shouldn't be possible.
We may need to add an ignore_cron_control parameter or similar to LaunchpadCronSc
Related branches
lp:~cjwatson/launchpad/publish-ftpmaster-cron-control
- William Grant (community): Approve (code)
-
Diff: 98 lines (+30/-8)3 files modifiedlib/lp/archivepublisher/scripts/publish_ftpmaster.py (+3/-2)
lib/lp/archivepublisher/tests/test_publish_ftpmaster.py (+19/-0)
lib/lp/services/scripts/base.py (+8/-6)
| tags: | added: soyuz-publish |
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Colin Watson (cjwatson) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r18290 <http://