User translations showing broken links

Bug #164530 reported by Diogo Matsubara
10
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
j.c.sackett

Bug Description

As seen in OOPS-691S57, the translation import queue page
* As anonymous.
* Visit https://translations.launchpad.net/~matsubara
* View the "wammu in Wammu stable" link
* 404

If the template is not accessible, we should not linkify to them.

Related branches

Revision history for this message
Данило Шеган (danilo) wrote :

I believe this is a very hard to achieve situation. For it to happen, we have to approve a potemplate first, then hide it, yet keep getting imports for it (which get auto-approved for hidden templates). A fix might be to not auto-approve entries for hiddent products, distros or templates.

Changed in rosetta:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Christian Reis (kiko) wrote :

Well, hard to acheive or not, we still generate 404s because of it. Can we just check_permission() and not display them if they aren't accessible?

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

This also happens with normal, enabled templates in projects that have not indicated that they use Launchpad for translation. We came across two examples today: gconf and libgnomeui.

Changed in launchpad:
importance: Medium → Critical
tags: added: oops
Curtis Hovey (sinzui)
description: updated
Curtis Hovey (sinzui)
tags: added: 404
Curtis Hovey (sinzui)
description: updated
Revision history for this message
Curtis Hovey (sinzui) wrote :

OOPS-7520440599559e63dbfb43c39b44f897 shows:
  URL: https://translations.launchpad.net/wammu/stable/+pots/wammu
  Referrer: https://translations.launchpad.net/~matsubara

wammu no longer uses Lp Translations, so the pots are not accessible to regular users.
1. Listings like https://translations.launchpad.net/~matsubara should not return results for project that do not use Lp Translations

description: updated
summary: - Translation import queue showing broken links
+ User translations showing broken links
Revision history for this message
Curtis Hovey (sinzui) wrote :

This issue historically affected the import queue for distros. Change to pages, linking rules, approvals, and the infrastructure for message approvals fixed issues where untraversable POTs were shown.

j.c.sackett (jcsackett)
Changed in launchpad:
assignee: nobody → j.c.sackett (jcsackett)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.