User translations showing broken links
Bug #164530 reported by
Diogo Matsubara
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
j.c.sackett |
Bug Description
As seen in OOPS-691S57, the translation import queue page
* As anonymous.
* Visit https:/
* View the "wammu in Wammu stable" link
* 404
If the template is not accessible, we should not linkify to them.
Related branches
lp:~jcsackett/launchpad/broken-links-person-translations
- Curtis Hovey (community): Approve (code)
-
Diff: 63 lines (+15/-2)3 files modifiedlib/lp/translations/browser/person.py (+6/-1)
lib/lp/translations/browser/tests/test_persontranslationview.py (+7/-0)
lib/lp/translations/model/translationsperson.py (+2/-1)
Changed in launchpad: | |
importance: | Medium → Critical |
tags: | added: oops |
description: | updated |
tags: | added: 404 |
description: | updated |
Changed in launchpad: | |
assignee: | nobody → j.c.sackett (jcsackett) |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I believe this is a very hard to achieve situation. For it to happen, we have to approve a potemplate first, then hide it, yet keep getting imports for it (which get auto-approved for hidden templates). A fix might be to not auto-approve entries for hiddent products, distros or templates.