Quickly-undone actions shouldn't send mail notifications
Bug #164196 reported by
Matthew Paul Thomas
This bug affects 4 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Yellow Squad | ||
Bug Description
1. Assign a bug to someone.
2. Within five minutes, undo the assignment.
What happens: The mistaken assignee receives a confusing e-mail notification.
What should happen: Nobody receives any e-mail notification at all.
Launchpad should not send notifications about anything that is undone within five minutes -- assignee, description, tags, importance, whatever. Assigning a private bug to someone who shouldn't see it is merely the most important example.
Related branches
lp:~gary/launchpad/bug164196-2
- Данило Шеган (community): Approve
-
Diff: 1212 lines (+691/-80)8 files modifiedlib/lp/bugs/adapters/bugchange.py (+38/-12)
lib/lp/bugs/browser/bugtask.py (+13/-6)
lib/lp/bugs/doc/bugactivity.txt (+8/-3)
lib/lp/bugs/doc/bugnotification-sending.txt (+23/-21)
lib/lp/bugs/model/bugactivity.py (+35/-3)
lib/lp/bugs/scripts/bugnotification.py (+64/-18)
lib/lp/bugs/scripts/tests/test_bugnotification.py (+426/-16)
lib/lp/bugs/tests/test_bugchanges.py (+84/-1)
lp:~gary/launchpad/bug164196-1
- Robert Collins (community): Approve
- Stuart Bishop (community): Approve (db)
- Данило Шеган (community): Approve (code)
-
Diff: 293 lines (+50/-52)11 files modifieddatabase/schema/comments.sql (+1/-0)
database/schema/patch-2208-46-0.sql (+8/-0)
lib/lp/bugs/configure.zcml (+0/-6)
lib/lp/bugs/doc/bugnotifications.txt (+16/-0)
lib/lp/bugs/interfaces/bug.py (+5/-2)
lib/lp/bugs/interfaces/bugnotification.py (+6/-1)
lib/lp/bugs/model/bug.py (+6/-4)
lib/lp/bugs/model/bugnotification.py (+4/-2)
lib/lp/bugs/subscribers/bug.py (+0/-10)
lib/lp/bugs/subscribers/bugactivity.py (+2/-26)
lib/lp/bugs/tests/test_bugnotification.py (+2/-1)
lp:~gary/launchpad/bug164196-3
- Robert Collins (community): Approve
- Stuart Bishop (community): Approve (db)
- Aaron Bentley (community): Approve
-
Diff: 519 lines (+140/-30)13 files modifiedcronscripts/send-bug-notifications.py (+8/-1)
database/schema/comments.sql (+1/-0)
database/schema/patch-2208-45-0.sql (+12/-0)
lib/lp/bugs/doc/bugnotification-sending.txt (+61/-19)
lib/lp/bugs/doc/bugnotification-threading.txt (+3/-3)
lib/lp/bugs/enum.py (+27/-0)
lib/lp/bugs/interfaces/bugnotification.py (+9/-0)
lib/lp/bugs/mail/tests/test_bug_task_assignment.py (+2/-2)
lib/lp/bugs/mail/tests/test_bug_task_modification.py (+1/-1)
lib/lp/bugs/model/bugnotification.py (+6/-0)
lib/lp/bugs/scripts/bugnotification.py (+4/-1)
lib/lp/bugs/scripts/tests/test_bugnotification.py (+4/-2)
lib/lp/bugs/tests/test_bugchanges.py (+2/-1)
| description: | updated |
| description: | updated |
| Changed in malone: | |
| status: | New → Confirmed |
| tags: | added: story-better-bug-notification |
| Changed in malone: | |
| status: | Confirmed → Triaged |
| Changed in malone: | |
| status: | Triaged → In Progress |
| Changed in malone: | |
| status: | In Progress → Triaged |
| status: | Triaged → In Progress |
| importance: | Undecided → High |
| Changed in malone: | |
| status: | In Progress → Triaged |
| Changed in launchpad: | |
| assignee: | nobody → Launchpad Yellow Squad (yellow) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| Changed in launchpad: | |
| milestone: | none → 11.03 |
| tags: | added: qa-untestable |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
| tags: | removed: qa-untestable |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r12367 (http://