Launchpad itself

support for building private snaps

Bug #1639975 reported by dann frazier
44
This bug affects 8 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Thiago F. Pappacena
launchpad-buildd
Fix Released
High
Colin Watson

Bug Description

I would like the ability to build a private snap within LP. Specifically, I'd like to be able to use a private LP code repository w/ my snapcraft.yaml, and have it build w/ access to a private PPA owned by the same user/team.

When I attempted to do this, I found that once I set my snapcraft branch to "private", the "Create snap package" option disappeared.

Related branches

lp:~cjwatson/launchpad/snap-build-send-private
William Grant (community): Approve (code)
Diff: 79 lines (+16/-0)
2 files modified
lib/lp/snappy/model/snapbuildbehaviour.py (+1/-0)
lib/lp/snappy/tests/test_snapbuildbehaviour.py (+15/-0)
lp:~cjwatson/launchpad-buildd/snap-private
William Grant (community): Approve (code)
Diff: 172 lines (+84/-6)
5 files modified
debian/changelog (+2/-0)
lpbuildd/snap.py (+3/-0)
lpbuildd/target/build_snap.py (+7/-6)
lpbuildd/target/tests/test_build_snap.py (+33/-0)
lpbuildd/tests/test_snap.py (+39/-0)
lp:~cjwatson/launchpad/snap-build-macaroon
William Grant (community): Approve (code)
Diff: 977 lines (+469/-210)
11 files modified
lib/lp/code/model/codeimportjob.py (+30/-42)
lib/lp/code/model/tests/test_codeimportjob.py (+27/-22)
lib/lp/code/xmlrpc/git.py (+2/-2)
lib/lp/services/authserver/tests/test_authserver.py (+23/-38)
lib/lp/services/macaroons/interfaces.py (+19/-10)
lib/lp/services/macaroons/model.py (+132/-0)
lib/lp/snappy/configure.zcml (+8/-0)
lib/lp/snappy/model/snapbuild.py (+58/-1)
lib/lp/snappy/tests/test_snapbuild.py (+121/-1)
lib/lp/soyuz/model/binarypackagebuild.py (+43/-72)
lib/lp/soyuz/tests/test_binarypackagebuild.py (+6/-22)
lp:~cjwatson/launchpad/authserver-issue-macaroon
William Grant (community): Approve (code)
Diff: 479 lines (+176/-28)
9 files modified
lib/lp/code/model/tests/test_codeimportjob.py (+12/-0)
lib/lp/services/authserver/interfaces.py (+17/-2)
lib/lp/services/authserver/tests/test_authserver.py (+49/-10)
lib/lp/services/authserver/xmlrpc.py (+56/-9)
lib/lp/services/macaroons/interfaces.py (+5/-1)
lib/lp/services/macaroons/model.py (+2/-0)
lib/lp/snappy/model/snapbuild.py (+3/-6)
lib/lp/snappy/tests/test_snapbuild.py (+18/-0)
lib/lp/soyuz/tests/test_binarypackagebuild.py (+14/-0)
lp:~cjwatson/launchpad/snap-build-behaviour-macaroon
William Grant (community): Approve (code)
Diff: 221 lines (+113/-0)
5 files modified
configs/development/launchpad-lazr.conf (+1/-0)
lib/lp/buildmaster/model/buildfarmjobbehaviour.py (+4/-0)
lib/lp/services/config/schema-lazr.conf (+10/-0)
lib/lp/snappy/model/snapbuildbehaviour.py (+20/-0)
lib/lp/snappy/tests/test_snapbuildbehaviour.py (+78/-0)
lp:~cjwatson/launchpad/snap-check-request-private-git
Rejected for merging into lp:launchpad
Launchpad code reviewers: Pending requested
Diff: 281 lines (+140/-16) (has conflicts)
5 files modified
lib/lp/snappy/interfaces/snap.py (+31/-2)
lib/lp/snappy/model/snap.py (+9/-4)
lib/lp/snappy/model/snapbuildbehaviour.py (+3/-9)
lib/lp/snappy/tests/test_snap.py (+96/-0)
lib/lp/snappy/tests/test_snapbuildbehaviour.py (+1/-1)
lp:~cjwatson/launchpad/snap-change-code-check-privacy
William Grant (community): Approve (code)
Diff: 413 lines (+225/-24)
7 files modified
lib/lp/code/model/branch.py (+2/-0)
lib/lp/code/model/gitrepository.py (+2/-0)
lib/lp/snappy/browser/snap.py (+27/-8)
lib/lp/snappy/browser/tests/test_snap.py (+66/-1)
lib/lp/snappy/interfaces/snap.py (+4/-6)
lib/lp/snappy/model/snap.py (+49/-9)
lib/lp/snappy/tests/test_snap.py (+75/-0)
lp:~cjwatson/launchpad/snap-build-record-code
Rejected for merging into lp:launchpad
Launchpad code reviewers: Pending requested
Diff: 524 lines (+244/-23)
11 files modified
lib/lp/code/model/branch.py (+17/-4)
lib/lp/code/model/gitrepository.py (+15/-3)
lib/lp/code/model/tests/test_branch.py (+3/-1)
lib/lp/code/model/tests/test_gitrepository.py (+3/-1)
lib/lp/security.py (+25/-4)
lib/lp/snappy/interfaces/snapbuild.py (+36/-0)
lib/lp/snappy/model/snap.py (+2/-1)
lib/lp/snappy/model/snapbuild.py (+49/-5)
lib/lp/snappy/model/snapbuildbehaviour.py (+2/-0)
lib/lp/snappy/tests/test_snapbuild.py (+91/-3)
lib/lp/testing/factory.py (+1/-1)
lp:~cjwatson/launchpad/db-snap-build-record-code
Rejected for merging into lp:launchpad/db-devel
Launchpad code reviewers: Pending (db) requested
Diff: 38 lines (+23/-0)
2 files modified
database/schema/patch-2210-02-0.sql (+22/-0)
lib/lp/code/doc/branch.txt (+1/-0)
~pappacena/launchpad:snap-pillar-subscribe-removal-job
Colin Watson (community): Approve
Diff: 890 lines (+199/-85)
16 files modified
database/schema/security.cfg (+2/-0)
lib/lp/blueprints/model/specification.py (+2/-2)
lib/lp/blueprints/tests/test_specification.py (+4/-4)
lib/lp/bugs/model/bug.py (+3/-3)
lib/lp/code/browser/branchsubscription.py (+2/-2)
lib/lp/code/browser/gitsubscription.py (+2/-2)
lib/lp/code/model/branch.py (+2/-2)
lib/lp/code/model/gitrepository.py (+1/-1)
lib/lp/code/model/tests/test_branchsubscription.py (+3/-3)
lib/lp/registry/model/sharingjob.py (+36/-1)
lib/lp/registry/services/sharingservice.py (+15/-12)
lib/lp/registry/services/tests/test_sharingservice.py (+11/-7)
lib/lp/registry/tests/test_sharingjob.py (+56/-10)
lib/lp/snappy/interfaces/snap.py (+4/-0)
lib/lp/snappy/model/snap.py (+36/-12)
lib/lp/snappy/tests/test_snap.py (+20/-24)
~pappacena/launchpad:snap-pillar-edit
Colin Watson (community): Approve
Diff: 618 lines (+251/-124) (has conflicts)
6 files modified
lib/lp/snappy/browser/snap.py (+80/-50)
lib/lp/snappy/browser/tests/test_snap.py (+143/-50)
lib/lp/snappy/interfaces/snap.py (+14/-12)
lib/lp/snappy/model/snap.py (+2/-12)
lib/lp/snappy/templates/snap-edit.pt (+6/-0)
lib/lp/snappy/templates/snap-new.pt (+6/-0)
~pappacena/launchpad:snap-pillar-product-url
Colin Watson (community): Approve
Diff: 265 lines (+94/-14)
9 files modified
lib/lp/registry/browser/person.py (+6/-2)
lib/lp/registry/browser/personproduct.py (+9/-1)
lib/lp/snappy/browser/configure.zcml (+1/-2)
lib/lp/snappy/browser/snap.py (+27/-1)
lib/lp/snappy/browser/tests/test_snap.py (+10/-3)
lib/lp/snappy/interfaces/snap.py (+3/-0)
lib/lp/snappy/model/snap.py (+12/-0)
lib/lp/snappy/tests/test_snap.py (+24/-4)
lib/lp/snappy/tests/test_snapbuild.py (+2/-1)
~pappacena/launchpad:snap-pillar-list-filters
Colin Watson (community): Approve
Diff: 323 lines (+225/-17)
2 files modified
lib/lp/snappy/browser/tests/test_snaplisting.py (+201/-1)
lib/lp/snappy/model/snap.py (+24/-16)
~pappacena/launchpad:snap-pillar-db-indexes
William Grant (community): Approve (db)
Diff: 20 lines (+14/-0)
1 file modified
database/schema/patch-2210-26-2.sql (+14/-0)
~pappacena/launchpad:snap-pillar-subscribe-ui
Colin Watson (community): Approve
Diff: 1187 lines (+777/-56)
17 files modified
lib/lp/code/browser/branchsubscription.py (+1/-6)
lib/lp/code/browser/gitsubscription.py (+1/-6)
lib/lp/registry/tests/test_personmerge.py (+5/-4)
lib/lp/security.py (+36/-10)
lib/lp/snappy/browser/configure.zcml (+40/-1)
lib/lp/snappy/browser/snap.py (+34/-1)
lib/lp/snappy/browser/snapsubscription.py (+175/-0)
lib/lp/snappy/browser/tests/test_snap.py (+69/-1)
lib/lp/snappy/browser/tests/test_snapsubscription.py (+264/-0)
lib/lp/snappy/configure.zcml (+12/-1)
lib/lp/snappy/interfaces/snap.py (+17/-3)
lib/lp/snappy/model/snap.py (+21/-5)
lib/lp/snappy/templates/snap-index.pt (+5/-1)
lib/lp/snappy/templates/snap-portlet-subscribers-content.pt (+31/-0)
lib/lp/snappy/templates/snap-portlet-subscribers.pt (+29/-0)
lib/lp/snappy/templates/snapsubscription-edit.pt (+25/-0)
lib/lp/snappy/tests/test_snap.py (+12/-17)
~pappacena/launchpad:snap-pillar-subscribe-removal-job
Superseded for merging into launchpad:master
Colin Watson (community): Approve
Diff: 890 lines (+199/-85)
16 files modified
database/schema/security.cfg (+2/-0)
lib/lp/blueprints/model/specification.py (+2/-2)
lib/lp/blueprints/tests/test_specification.py (+4/-4)
lib/lp/bugs/model/bug.py (+3/-3)
lib/lp/code/browser/branchsubscription.py (+2/-2)
lib/lp/code/browser/gitsubscription.py (+2/-2)
lib/lp/code/model/branch.py (+2/-2)
lib/lp/code/model/gitrepository.py (+1/-1)
lib/lp/code/model/tests/test_branchsubscription.py (+3/-3)
lib/lp/registry/model/sharingjob.py (+36/-1)
lib/lp/registry/services/sharingservice.py (+15/-12)
lib/lp/registry/services/tests/test_sharingservice.py (+11/-7)
lib/lp/registry/tests/test_sharingjob.py (+56/-10)
lib/lp/snappy/interfaces/snap.py (+4/-0)
lib/lp/snappy/model/snap.py (+36/-12)
lib/lp/snappy/tests/test_snap.py (+20/-24)
~pappacena/launchpad:snap-pillar-subscribe-ui
Superseded for merging into launchpad:master
Launchpad code reviewers: Pending requested
Diff: 729 lines (+423/-37)
13 files modified
lib/lp/registry/tests/test_personmerge.py (+4/-4)
lib/lp/security.py (+30/-9)
lib/lp/snappy/browser/configure.zcml (+40/-1)
lib/lp/snappy/browser/snap.py (+28/-1)
lib/lp/snappy/browser/snapsubscription.py (+173/-0)
lib/lp/snappy/configure.zcml (+10/-1)
lib/lp/snappy/interfaces/snap.py (+19/-0)
lib/lp/snappy/model/snap.py (+23/-6)
lib/lp/snappy/templates/snap-index.pt (+1/-0)
lib/lp/snappy/templates/snap-portlet-subscribers-content.pt (+31/-0)
lib/lp/snappy/templates/snap-portlet-subscribers.pt (+29/-0)
lib/lp/snappy/templates/snapsubscription-edit.pt (+25/-0)
lib/lp/snappy/tests/test_snap.py (+10/-15)
~pappacena/launchpad:snap-pillar-subscribe
Colin Watson (community): Approve
Diff: 666 lines (+324/-24)
9 files modified
lib/lp/registry/personmerge.py (+21/-4)
lib/lp/registry/tests/test_personmerge.py (+37/-2)
lib/lp/snappy/browser/tests/test_snap.py (+5/-0)
lib/lp/snappy/interfaces/snapsubscription.py (+42/-0)
lib/lp/snappy/model/snap.py (+62/-7)
lib/lp/snappy/model/snapsubscription.py (+62/-0)
lib/lp/snappy/tests/test_snap.py (+79/-7)
lib/lp/snappy/tests/test_snapbuild.py (+7/-2)
lib/lp/testing/factory.py (+9/-2)
~pappacena/launchpad:snap-pillar-reconcile-access
Colin Watson (community): Approve
Diff: 368 lines (+188/-13)
6 files modified
lib/lp/snappy/browser/snap.py (+7/-0)
lib/lp/snappy/browser/tests/test_snap.py (+14/-3)
lib/lp/snappy/interfaces/snap.py (+6/-0)
lib/lp/snappy/model/snap.py (+33/-2)
lib/lp/snappy/tests/test_snap.py (+112/-2)
lib/lp/testing/factory.py (+16/-6)
~pappacena/launchpad:snap-pillar-accesspolicy
Colin Watson (community): Approve
Diff: 652 lines (+205/-56)
9 files modified
lib/lp/registry/browser/pillar.py (+1/-1)
lib/lp/registry/interfaces/accesspolicy.py (+1/-0)
lib/lp/registry/interfaces/sharingservice.py (+19/-6)
lib/lp/registry/model/accesspolicy.py (+16/-8)
lib/lp/registry/services/sharingservice.py (+42/-13)
lib/lp/registry/services/tests/test_sharingservice.py (+1/-1)
lib/lp/snappy/interfaces/snap.py (+9/-0)
lib/lp/snappy/model/snap.py (+82/-27)
lib/lp/snappy/tests/test_snap.py (+34/-0)
~pappacena/launchpad:snap-pillar-accesspolicy
Superseded for merging into launchpad:master
Launchpad code reviewers: Pending requested
Diff: 661 lines (+211/-34)
11 files modified
lib/lp/registry/browser/pillar.py (+1/-1)
lib/lp/registry/interfaces/accesspolicy.py (+1/-0)
lib/lp/registry/interfaces/sharingservice.py (+19/-6)
lib/lp/registry/model/accesspolicy.py (+16/-8)
lib/lp/registry/services/sharingservice.py (+42/-13)
lib/lp/registry/services/tests/test_sharingservice.py (+1/-1)
lib/lp/snappy/browser/snap.py (+13/-2)
lib/lp/snappy/browser/tests/test_snap.py (+16/-0)
lib/lp/snappy/interfaces/snap.py (+11/-2)
lib/lp/snappy/model/snap.py (+55/-1)
lib/lp/snappy/tests/test_snap.py (+36/-0)
~pappacena/launchpad:snap-pillar-ui
Colin Watson (community): Approve
Diff: 751 lines (+275/-68)
7 files modified
lib/lp/registry/personmerge.py (+1/-1)
lib/lp/snappy/browser/snap.py (+69/-15)
lib/lp/snappy/browser/tests/test_snap.py (+84/-3)
lib/lp/snappy/interfaces/snap.py (+16/-7)
lib/lp/snappy/model/snap.py (+83/-31)
lib/lp/snappy/tests/test_snap.py (+12/-6)
lib/lp/testing/factory.py (+10/-5)
~pappacena/launchpad:snap-pillar-db
William Grant (community): Approve (db)
Colin Watson (community): Approve (db)
Diff: 178 lines (+137/-0)
3 files modified
database/schema/patch-2210-26-1.sql (+130/-0)
database/schema/security.cfg (+3/-0)
lib/lp/registry/personmerge.py (+4/-0)
~pappacena/launchpad:snap-pillar
Colin Watson (community): Approve
Diff: 372 lines (+119/-14)
5 files modified
database/schema/security.cfg (+3/-0)
lib/lp/snappy/interfaces/snap.py (+33/-4)
lib/lp/snappy/model/snap.py (+58/-5)
lib/lp/snappy/tests/test_snap.py (+16/-2)
lib/lp/testing/factory.py (+9/-3)
~cjwatson/launchpad:snap-check-request-private-git
Launchpad code reviewers: Pending requested
Diff: 282 lines (+140/-16)
5 files modified
lib/lp/snappy/interfaces/snap.py (+31/-2)
lib/lp/snappy/model/snap.py (+9/-4)
lib/lp/snappy/model/snapbuildbehaviour.py (+3/-9)
lib/lp/snappy/tests/test_snap.py (+96/-0)
lib/lp/snappy/tests/test_snapbuildbehaviour.py (+1/-1)
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Any updates on this request?

Revision history for this message
Colin Watson (cjwatson) wrote : Re: [Bug 1639975] Re: support for building private snaps

It's a substantial chunk of work, and it hasn't yet made it far enough
up the OLS/snap-store team's roadmap to actually get scheduled.

Revision history for this message
Erik (eberkund) wrote :

Any updates on this? I would purchase a commercial license in a second if this became available.

Colin Watson (cjwatson)
tags: added: feature lp-snappy soyuz-build
Colin Watson (cjwatson)
Changed in launchpad:
status: New → Triaged
importance: Undecided → High
Changed in launchpad-buildd:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

I'm told that this bug is one of several problems that frustrates our response for embargoed snapd hotfix security updates. I believe the snapd team will be reaching out in the coming days to discuss paths forward.

Revision history for this message
Colin Watson (cjwatson) wrote :

We have a complete design for this - it just needs to get development time carved out.

Colin Watson (cjwatson)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Colin Watson (cjwatson)
Colin Watson (cjwatson)
Changed in launchpad-buildd:
status: Triaged → In Progress
assignee: nobody → Colin Watson (cjwatson)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r18903 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/18903) is part of this bug's fix.

tags: added: qa-needstesting
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Colin Watson (cjwatson) wrote :

The launchpad-buildd part of this (though that's only a small and relatively boring part of this work) was released in version 168 and is now on production.

Changed in launchpad-buildd:
status: In Progress → Fix Released
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r18917 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/18917) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r18942 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/18942) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r18943 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/18943) is part of this bug's fix.

Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r18968 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/18968) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
raul ochoa (raul1886)
Changed in launchpad-buildd:
assignee: Colin Watson (cjwatson) → raul ochoa (raul1886)
Colin Watson (cjwatson)
Changed in launchpad-buildd:
assignee: raul ochoa (raul1886) → Colin Watson (cjwatson)
Colin Watson (cjwatson)
Changed in launchpad:
assignee: Colin Watson (cjwatson) → Thiago F. Pappacena (pappacena)
Thiago F. Pappacena (pappacena)
Changed in launchpad:
status: In Progress → Fix Released
Revision history for this message
Thiago F. Pappacena (pappacena) wrote :

We have now in production the possibility of creating private Snaps.

In order to do so, the user must associate the Snap to a project, so it will follow the sharing policies of that project (see https://launchpad.net/<project>/+sharing page).

This feature is experimental and restricted to a few Canonical teams for now, but it should go fully public in a few days.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.