user.getMergeProposals(status="Merged") consistently timing out for some users
Bug #1619772 reported by
James Troup
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Colin Watson | ||
Bug Description
user.getMergePr
from me for certain users. It works fine for stub, but doesn't work
for Spads. Example OOPSes:
* OOPS-67cf5859c34d9ddfa83882f888d52056
* OOPS-5c10709ba4328789ef8cd5f02fe22192
Colin thinks that this "looks like death by a thousand queries thanks
to security adapters; it should be fixable with some permissions
preloading"
Related branches
lp:~cjwatson/launchpad/getMergeProposals-timeout
- William Grant (community): Approve (code)
-
Diff: 156 lines (+81/-8)3 files modifiedlib/lp/code/interfaces/hasbranches.py (+5/-3)
lib/lp/code/model/branchmergeproposal.py (+20/-3)
lib/lp/code/model/tests/test_hasbranches.py (+56/-2)
| Changed in launchpad: | |
| assignee: | nobody → Colin Watson (cjwatson) |
| status: | New → In Progress |
| tags: | added: lp-code oops timeout |
| Changed in launchpad: | |
| importance: | Undecided → Critical |
| tags: | added: code-review |
| tags: | added: api |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r18186 <http://