Conch blows up when processes end due to signals

[Jonathan Lange]

I got this while running the codehosting acceptance tests.

canonical.codehosting.tests.test_acceptance.AcceptanceTests.test_push_team_branch(bzr+ssh)Traceback (most recent call last):
  File "/home/jml/canonical/lp-branches/trunk/utilities/../lib/twisted/internet/process.py", line 639, in childConnectionLost
    if p == child:
  File "/home/jml/canonical/lp-branches/trunk/utilities/../lib/twisted/internet/process.py", line 652, in maybeCallProcessEnded

  File "/home/jml/canonical/lp-branches/trunk/utilities/../lib/twisted/internet/process.py", line 540, in reapProcess
    reader = self.processReaderFactory(reactor, self, childFD,
  File "/home/jml/canonical/lp-branches/trunk/utilities/../lib/twisted/internet/process.py", line 628, in processEnded
    fcntl.F_SETFD, old & ~fcntl.FD_CLOEXEC)
--- <exception caught here> ---
  File "/home/jml/canonical/lp-branches/trunk/utilities/../lib/twisted/internet/process.py", line 668, in maybeCallProcessEnded
    # if childFD is not in the list of pipes, assume that it is already
  File "/home/jml/canonical/lp-branches/logging-bug-152746/lib/twisted/conch/ssh/session.py", line 199, in processEnded
    self.session.conn.sendRequest(self.session, 'exit-status', struct.pack('!L', reason.value.exitCode))
struct.error: required argument is not an integer

Don't know whether this is a Twisted bug or a Launchpad bug.

OOPS-787SMPSSH12

[Diogo Matsubara (matsubara)]

Bumping importance as this OOPS is the top one for codehosting

[Jonathan Lange (jml)]

The fix for this landed on our copy of Twisted a while ago -- sorry for not tracking it.