can not generate diff with non-UTF-8 encoding files
Bug #1589411 reported by
Shawn Wang
on 2016-06-06
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Launchpad itself |
Critical
|
Colin Watson | ||
Bug Description
We have some test data that encoding by GBK.
Here is the MP.
https:/
the diff:
https:/
Related branches
lp:~cjwatson/launchpad/simplejson-3.8.2
- William Grant: Approve (code) on 2016-06-06
-
Diff: 42 lines (+16/-1)2 files modifiedlib/lp/code/model/tests/test_githosting.py (+15/-0)
versions.cfg (+1/-1)
Shawn Wang (shawn111)
on 2016-06-06
| description: | updated |
| description: | updated |
| Colin Watson (cjwatson) wrote : | #1 |
| affects: | turnip → launchpad |
| Changed in launchpad: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| importance: | High → Critical |
| tags: | added: git lp-code oops |
Colin Watson (cjwatson)
on 2016-06-06
| Changed in launchpad: | |
| assignee: | nobody → Colin Watson (cjwatson) |
| status: | Triaged → In Progress |
| Launchpad QA Bot (lpqabot) wrote : | #2 |
Fixed in stable r18095 <http://
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
Colin Watson (cjwatson)
on 2016-06-06
| tags: |
added: qa-ok removed: qa-needstesting |
Colin Watson (cjwatson)
on 2016-06-07
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Actually looks like a Launchpad-side problem. I reproduced this locally, and turnip is returning the compare-merge response just fine, but LP crashes when it tries to decode it. It's probably as simple as upgrading LP's simplejson version (since requests uses simplejson if it can).