Show commit messages in Git-based merge proposals
Bug #1550118 reported by
Alex Tu
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
When a reviewer review a MP, he not only review the change of code but also review the commit message.
So, it would be convenient to also auto post the commit message on MP.
Related branches
lp:~cjwatson/launchpad/git-mp-commits
- William Grant: Approve (code)
-
Diff: 524 lines (+213/-73)11 files modifiedlib/lp/code/browser/branchmergeproposal.py (+16/-4)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+42/-7)
lib/lp/code/interfaces/branchmergeproposal.py (+4/-1)
lib/lp/code/model/branchmergeproposal.py (+54/-40)
lib/lp/code/stories/branches/xx-code-review-comments.txt (+50/-0)
lib/lp/code/templates/branchmergeproposal-index.pt (+8/-0)
lib/lp/code/templates/branchmergeproposal-resubmit.pt (+21/-11)
lib/lp/code/templates/codereviewcomment-reply.pt (+2/-2)
lib/lp/code/templates/codereviewnewrevisions-footer.pt (+13/-5)
lib/lp/code/templates/codereviewnewrevisions-header.pt (+1/-1)
lib/lp/code/templates/git-macros.pt (+2/-2)
| tags: | added: feature git lp-code |
| Changed in launchpad: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Colin Watson (cjwatson) |
| summary: |
- [git][Merge-Proposal] should show git commit message + Show commit messages in Git-based merge proposals |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-untestable |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-untestable |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r18046 (http://