GitHostingClient timeout too low to detect merges on large repos
Bug #1502748 reported by
Alex Tu
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
William Grant | ||
Bug Description
We use launchpad to host our git repositories.
And sometimes the "Preview Diff" in merge proposal give us the incorrect information, it compared incorrect pair of commits.
ex. https:/
It compared 3fada00 and b0e0dbe, but it should compare 3fada00 and 9e58f51.
Here is some more information about the whole tree:
http://
Related branches
lp:~wgrant/launchpad/bug-1502748
- Colin Watson (community): Approve
-
Diff: 12 lines (+1/-1)1 file modifiedlib/lp/code/model/githosting.py (+1/-1)
| description: | updated |
| summary: |
- [git]Preview Diff in merge proposal compared incorrect pair of commits. + GitRef commit information can get out of date |
Revision history for this message
| William Grant (wgrant) wrote Re: GitRef commit information can get out of date | #1 |
| summary: |
- GitRef commit information can get out of date + GitHostingClient timeout too low to detect merges on large repos |
| Changed in launchpad: | |
| importance: | Undecided → Critical |
| status: | New → Triaged |
| tags: | added: git oops |
| Changed in launchpad: | |
| assignee: | nobody → William Grant (wgrant) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Colin Watson (cjwatson) wrote | #3 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
From OOPS-6cf25eda7581ff87dd17edb3da352e80 (already expired):
GitRepositorySc
Five seconds is quite optimistic for a kernel merge.