GitHostingClient timeout too low to detect merges on large repos
Bug #1502748 reported by
Alex Tu
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
William Grant |
Bug Description
We use launchpad to host our git repositories.
And sometimes the "Preview Diff" in merge proposal give us the incorrect information, it compared incorrect pair of commits.
ex. https:/
It compared 3fada00 and b0e0dbe, but it should compare 3fada00 and 9e58f51.
Here is some more information about the whole tree:
http://
Related branches
lp:~wgrant/launchpad/bug-1502748
- Colin Watson (community): Approve
-
Diff: 12 lines (+1/-1)1 file modifiedlib/lp/code/model/githosting.py (+1/-1)
description: | updated |
summary: |
- [git]Preview Diff in merge proposal compared incorrect pair of commits. + GitRef commit information can get out of date |
Changed in launchpad: | |
assignee: | nobody → William Grant (wgrant) |
status: | Triaged → In Progress |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
From OOPS-6cf25eda7581ff87dd17edb3da352e80 (already expired):
GitRepositorySc anFault: Failed to detect merges in Git repository: HTTPConnectionP ool(host= 'git.launchpad. net', port=19417): Read timed out. (read timeout=5.0)
Five seconds is quite optimistic for a kernel merge.