Enable passing version information to livefs builds
Bug #1496074 reported by
Dan Watkins
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Colin Watson |
Bug Description
Ubuntu cloud images contain a file (/etc/cloud/
In order to fully build cloud images using Launchpad buildds, we need some way of injecting this value in to the live-build process via the livefs.requestBuild API.
Related branches
lp:~cjwatson/launchpad/db-livefsbuild-version
- William Grant (community): Approve (db)
- Stuart Bishop: Pending (db) requested
-
Diff: 14 lines (+10/-0)1 file modifieddatabase/schema/patch-2209-56-2.sql (+10/-0)
lp:~cjwatson/launchpad/livefsbuild-version
- William Grant (community): Approve (code)
-
Diff: 196 lines (+44/-14)6 files modifiedlib/lp/soyuz/interfaces/livefs.py (+6/-2)
lib/lp/soyuz/interfaces/livefsbuild.py (+4/-3)
lib/lp/soyuz/model/livefs.py (+3/-2)
lib/lp/soyuz/model/livefsbuild.py (+12/-5)
lib/lp/soyuz/tests/test_livefs.py (+17/-0)
lib/lp/testing/factory.py (+2/-2)
Changed in launchpad: | |
assignee: | nobody → Colin Watson (cjwatson) |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think the most sensible approach here would be to add a LiveFSBuild.version column and allow that to be optionally set in LiveFS. requestBuild, overriding the default timestamp-based one (that version is informational from LP's point of view, so we don't have to enforce uniqueness or anything). The LiveFSBuild.version property is already passed to the build, so the rest will just work from there.