Launchpad itself

Enable passing version information to livefs builds

Bug #1496074 reported by Dan Watkins on 2015-09-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
​ Launchpad itself
Fix Released
High
Colin Watson
Also affects project (?) Also affects distribution/package Nominate for series

Bug Description

Ubuntu cloud images contain a file (/etc/cloud/build.info) that identifies the serial of the build. This is useful for debugging etc.

In order to fully build cloud images using Launchpad buildds, we need some way of injecting this value in to the live-build process via the livefs.requestBuild API.

Related branches

lp:~cjwatson/launchpad/db-livefsbuild-version
William Grant: Approve (db) on 2015-09-16
Stuart Bishop: Pending (db) requested 2015-09-15
Diff: 14 lines (+10/-0)
1 file modified
database/schema/patch-2209-56-2.sql (+10/-0)
lp:~cjwatson/launchpad/livefsbuild-version
William Grant: Approve (code) on 2015-09-15
Diff: 196 lines (+44/-14)
6 files modified
lib/lp/soyuz/interfaces/livefs.py (+6/-2)
lib/lp/soyuz/interfaces/livefsbuild.py (+4/-3)
lib/lp/soyuz/model/livefs.py (+3/-2)
lib/lp/soyuz/model/livefsbuild.py (+12/-5)
lib/lp/soyuz/tests/test_livefs.py (+17/-0)
lib/lp/testing/factory.py (+2/-2)
Colin Watson (cjwatson) wrote :

I think the most sensible approach here would be to add a LiveFSBuild.version column and allow that to be optionally set in LiveFS.requestBuild, overriding the default timestamp-based one (that version is informational from LP's point of view, so we don't have to enforce uniqueness or anything). The LiveFSBuild.version property is already passed to the build, so the rest will just work from there.

tags: added: soyuz-build trivial
Changed in launchpad:
status: New → Triaged
importance: Undecided → High
Colin Watson (cjwatson) on 2015-09-15
Changed in launchpad:
assignee: nobody → Colin Watson (cjwatson)
status: Triaged → In Progress
Launchpad QA Bot (lpqabot) wrote :

r13214 in db-stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/13214) is part of this bug's fix.

tags: added: qa-needstesting
Colin Watson (cjwatson) wrote :

2015-09-16 17:41:55,820 INFO 2209-56-2 applied just now in 0.1 seconds

tags: added: qa-ok
removed: qa-needstesting
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17743 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17743>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Colin Watson (cjwatson) on 2015-09-17
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant) on 2015-09-18
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.
Subscribing...

Other bug subscribers