Can't use gmail+new-verbose-footers to filter by group rationale

Bug #1493844 reported by Michael Terry on 2015-09-09
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Colin Watson

Bug Description

Gmail treats "Launchpad-Message-Rationale: Reviewer" the same as "Launchpad-Message-Rationale: Reviewer @" in searches and filters.

So I can't treat merge request mail-that-comes-in-only-because-my-team-is-the-maintainer-for-that-project differently than merges-I'm-actively-doing.

That seems like a useful distinction to be able to make (and one that I use in my own filtering -- my workaround now is to include the search term "Your team", but that's fragile)

Related branches

Colin Watson (cjwatson) wrote :

Perhaps we should switch to appending @your-username in that case. It would potentially break other people's filters.

tags: added: email
Changed in launchpad:
status: New → Triaged
importance: Undecided → Low
Michael Terry (mterry) wrote :

Or maybe "Launchpad-Message-Rationale: Reviewer via ~your-team" or something similar?

Colin Watson (cjwatson) wrote :

I think "Reviewer @your-username" would be semantically more sound - "via" is already used for something slightly different elsewhere, and I would rather not break existing team filters as well.

Michael Terry (mterry) wrote :

OK. Note that "Subscriber" has the same issue, though hopefully that's all the same code path in Launchpad anyway.

Colin Watson (cjwatson) wrote :

Yes, bugs go through a different code path because it was too heroic a job to convert them, but everything else goes through the same path for rationale construction.

We talked about this a bit on #launchpad-dev today. The problem with changing the existing rationales is that people may well have filters that direct anything without @ (i.e. notifications directed specifically at them) to their inbox and anything with @ to a "team junk I don't care about" mailbox, so adding @ would potentially cause people to not see notifications and not notice for some time.

How about sidestepping the issue and introducing a new header? X-Launchpad-Message-Subscriber or some such, that always identifies the person-or-team that the notification is being sent to. We could leave @ in X-Launchpad-Message-Rationale intact for compatibility, but the new preferred approach would be to filter on this new header.

Michael Terry (mterry) wrote :

Right. That "aimed at me" vs "team junk I don't care about" issue is exactly the filtering I'm trying to do.

I will point out that in terms of what you put in the FOOTER, which is ostensibly 99% for Gmail users: Gmail won't let you filter by @ at all (hence this bug). So there's no compatibility issue with existing filters.

But you keep talking about headers. So I'm assuming you're trying to keep the footers identical to the headers. In which case, yeah, 100% don't change the actual Rationale header. Only changing the footer version would make sense. But if you want them the same...

I'm fine with a new header.

Colin Watson (cjwatson) wrote :

Right, the footers are intentionally totally identical to the headers (well, anything that starts with X-Launchpad- and with the leading "X-" stripped). That's the only reason the expanded footer approach is sustainable. I wouldn't want to do anything that makes them different.

Colin Watson (cjwatson) on 2015-09-11
Changed in launchpad:
assignee: nobody → Colin Watson (cjwatson)
importance: Low → High
status: Triaged → In Progress
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Colin Watson (cjwatson) on 2015-09-14
tags: added: qa-ok
removed: qa-needstesting
Colin Watson (cjwatson) on 2015-09-14
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers