WebhookClient.deliver crashes if the endpoint times out

[Colin Watson]

I tried a webhook delivery to my ADSL (http://riva.dynamic.greenend.org.uk/), and apparently my router box times out HTTP requests rather than rejecting them as it really should; this produced https://oops.canonical.com/?oopsid=OOPS-86856e3812ab2bada21cf3f23ab8f83b.

  ReadTimeout: HTTPConnectionPool(host='webhooks-proxy.qastaging.paddev.net', port=3128): Read timed out. (read timeout=30)

    Traceback (most recent call last):
  Module lazr.jobrunner.jobrunner, line 194, in runJobHandleError
    self.runJob(job, fallback)
  Module lp.services.job.runner, line 302, in runJob
    super(BaseJobRunner, self).runJob(IRunnableJob(job), fallback)
  Module lazr.jobrunner.jobrunner, line 162, in runJob
    job.run()
  Module lp.services.webhooks.model, line 426, in run
    str(self.job_id), self.event_type, self.payload)
  Module lp.services.webhooks.client, line 87, in deliver
    resp = session.send(preq, proxies=proxies, timeout=timeout)
  Module requests.sessions, line 573, in send
    r = adapter.send(request, **kwargs)
  Module requests.adapters, line 433, in send
    raise ReadTimeout(e, request=request)
ReadTimeout: HTTPConnectionPool(host='webhooks-proxy.qastaging.paddev.net', port=3128): Read timed out. (read timeout=30)

[Launchpad QA Bot (lpqabot)]

Fixed in stable r17707 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17707>.

[William Grant (wgrant)]

In [21]: d.error_message
Out[21]: u'Connection error: Request timeout'