Launchpad itself

CodeReviewComment:+index OOPSes in the git case

Bug #1485907 reported by Colin Watson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Colin Watson

Bug Description

CodeReviewComment:+index OOPSes for comments on git-based merge proposals, for example:

  OOPS-20eab42e059438d65dbf43e5ae34252f

It's trying to resolve branch_merge_proposal.source_branch.bzr_identity rather than branch_merge_proposal.merge_source.identity. A public example is: https://code.qastaging.launchpad.net/~cjwatson/grub/+git/qas/+merge/254313/comments/632158

Related branches

lp:~cjwatson/launchpad/crc-index-git
Colin Watson (community): Approve
Diff: 94 lines (+23/-9)
2 files modified
lib/lp/code/browser/tests/test_codereviewcomment.py (+21/-7)
lib/lp/code/templates/codereviewcomment-index.pt (+2/-2)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17691 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17691>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Colin Watson (cjwatson)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.