Make it easier to select blocks of code in diffs

Bug #1483925 reported by Thomi Richards on 2015-08-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Low
Kit Randel

Bug Description

In the launchpad diff on a MP page (for example https://code.launchpad.net/~verterok/canonical-mojo-specs/conn-check-spec-manager/+merge/267719), it's sometimes useful to be able to select blocks of code and copy them.

Currently, you get the code, line numbers and diff markers (+/-).

It would be nice if you could select *just* the code. github diffs support this.

Related branches

lp:~blr/launchpad/diff-code-select-bug-1483925
Colin Watson: Approve on 2015-08-17
Thomi Richards (thomir) on 2015-08-11
description: updated
Kit Randel (blr) on 2015-08-11
Changed in launchpad:
assignee: nobody → Bayard 'kit' Randel (blr)
tags: added: css loggerhead ui
Kit Randel (blr) wrote :

Hi Thomi,

I've added a branch which makes the line number column unselectable, however the diff markers (+/-) are still preserved. Preserving the diff markers is the common behaviour on other sites (github etc.)

-kit

Changed in launchpad:
importance: Undecided → Low
William Grant (wgrant) on 2015-08-14
Changed in launchpad:
status: New → In Progress
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Kit Randel (blr) on 2015-09-01
tags: added: qa-ok
removed: qa-needstesting
Colin Watson (cjwatson) on 2015-09-01
Changed in launchpad:
status: Fix Committed → Fix Released
tags: removed: loggerhead
tags: added: code-review
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers