Make it easier to select blocks of code in diffs
Bug #1483925 reported by
Thomi Richards
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Kit Randel | ||
Bug Description
In the launchpad diff on a MP page (for example https:/
Currently, you get the code, line numbers and diff markers (+/-).
It would be nice if you could select *just* the code. github diffs support this.
Related branches
lp:~blr/launchpad/diff-code-select-bug-1483925
- Colin Watson (community): Approve
-
Diff: 116 lines (+22/-14)3 files modifiedlib/canonical/launchpad/icing/style.css (+6/-0)
lib/lp/app/browser/stringformatter.py (+7/-6)
lib/lp/app/browser/tests/test_stringformatter.py (+9/-8)
| description: | updated |
| Changed in launchpad: | |
| assignee: | nobody → Bayard 'kit' Randel (blr) |
| tags: | added: css loggerhead ui |
Revision history for this message
| Kit Randel (blr) wrote | #1 |
| Changed in launchpad: | |
| importance: | Undecided → Low |
| Changed in launchpad: | |
| status: | New → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| tags: | removed: loggerhead |
| tags: | added: code-review |
To post a comment you must log in.
Hi Thomi,
I've added a branch which makes the line number column unselectable, however the diff markers (+/-) are still preserved. Preserving the diff markers is the common behaviour on other sites (github etc.)
-kit