Launchpad itself

Upload notification body's Signed-By can be RFC2047-encoded

Bug #1479206 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
William Grant

Bug Description

lp.soyuz.adapters.notification.assemble_body adds a Signed-By line if it is distinct from Changed-By. But it inserts the result person_to_email into the body raw, even if that value is an RFC2047 representation only valid in headers.

See https://lists.ubuntu.com/archives/vivid-changes/2015-July/008856.html for an example.

Related branches

lp:~wgrant/launchpad/soyuz-notifications-unicode
Colin Watson (community): Approve
Diff: 535 lines (+82/-166)
5 files modified
lib/lp/archiveuploader/tests/test_utils.py (+2/-14)
lib/lp/archiveuploader/utils.py (+4/-20)
lib/lp/soyuz/adapters/notification.py (+58/-99)
lib/lp/soyuz/adapters/tests/test_notification.py (+17/-32)
lib/lp/soyuz/doc/soyuz-set-of-uploads.txt (+1/-1)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17648 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17648>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Colin Watson (cjwatson)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.