Can't add a comment in a side-by-side diff with a single click
Bug #1472112 reported by
Junien F
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Thiago F. Pappacena |
Bug Description
Hi,
Opened this bug as requested by wgrant. Apparently, the single-click handler is missing for side-by-side diffs, so one has to double-click on a diff line to be able to add a comment.
URL where you can reproduce : any side-by-side diff, eg https:/
Cheers
Related branches
~pappacena/launchpad:side-by-side-diff-comment-click
Merged
into
launchpad:master
- Colin Watson (community): Approve
-
Diff: 310 lines (+256/-5)4 files modifiedlib/canonical/launchpad/icing/style.css (+1/-1)
lib/lp/code/javascript/branchmergeproposal.inlinecomments.js (+9/-4)
lib/lp/code/javascript/tests/test_branchmergeproposal.ss_inlinecomments.html (+183/-0)
lib/lp/code/javascript/tests/test_branchmergeproposal.ss_inlinecomments.js (+63/-0)
Changed in launchpad: | |
assignee: | nobody → William Grant (wgrant) |
assignee: | William Grant (wgrant) → nobody |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: code-review easy javascript |
tags: | added: inline-comments |
Changed in launchpad: | |
assignee: | nobody → Thiago F. Pappacena (pappacena) |
Changed in launchpad: | |
status: | Triaged → In Progress |
Changed in launchpad: | |
status: | In Progress → Fix Committed |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.