MP diff emails are mangled
Bug #1472045 reported by
James Troup
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Kit Randel | ||
Bug Description
Thanks for introducing the reduced diff feature in MP emails;
unfortunately the output seems to be broken. Compare my comments on
here:
https:/
with what is sent by email:
Related branches
lp:~blr/launchpad/bug-1472045-demangle-inlinecomment-mail
- William Grant: Approve (code)
-
Diff: 735 lines (+611/-18)3 files modifiedlib/lp/code/mail/codereviewcomment.py (+1/-1)
lib/lp/code/mail/patches.py (+513/-0)
lib/lp/code/mail/tests/test_codereviewcomment.py (+97/-17)
| Changed in launchpad: | |
| importance: | Undecided → Critical |
| tags: | added: code-review email fallout regression |
| Changed in launchpad: | |
| assignee: | nobody → Bayard 'kit' Randel (blr) |
| Changed in launchpad: | |
| status: | New → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r17614 <http://