AttributeError: 'BinaryPatch' object has no attribute 'get_header'
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Kit Randel |
Bug Description
Noticed in the OOPS report, e.g. OOPS-50130d5386da2b311efcb88dd623336e:
AttributeError: 'BinaryPatch' object has no attribute 'get_header'
Traceback (most recent call last):
Module lazr.jobrunner.
self.
Module lp.services.
super(
Module lazr.jobrunner.
job.run()
Module lp.code.
mailer = CodeReviewComme
Module lp.code.
code_
Module lp.code.
self.
Module lp.code.
inline_
Module lp.code.
for ph in patch.get_
AttributeError: 'BinaryPatch' object has no attribute 'get_header'
Looks like a regression from recent work on inline comment mails. Critical per the zero OOPS policy.
Related branches
- William Grant (community): Approve (code)
-
Diff: 82 lines (+54/-0)2 files modifiedlib/lp/code/mail/codereviewcomment.py (+11/-0)
lib/lp/code/mail/tests/test_codereviewcomment.py (+43/-0)
Changed in launchpad: | |
assignee: | nobody → Bayard 'kit' Randel (blr) |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Fixed in stable r17606 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 17606>.