Refs in private Git repositories have no privacy banner
Bug #1457553 reported by
Colin Watson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Colin Watson |
Bug Description
Refs in private Git repositories don't show the usual privacy banner at the top of the page. They are in fact private anyway, but the lack of banner looks scary. I think it's just a matter of passing through the private attribute from the repository.
Related branches
lp:~cjwatson/launchpad/git-ref-privacy-banner
- William Grant (community): Approve (code)
-
Diff: 92 lines (+32/-1)3 files modifiedlib/lp/code/interfaces/gitref.py (+9/-1)
lib/lp/code/model/gitref.py (+5/-0)
lib/lp/code/model/tests/test_gitref.py (+18/-0)
Changed in launchpad: | |
assignee: | nobody → Colin Watson (cjwatson) |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r17518 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 17518>.