Git-based merge proposal URLs are located under (removable) references
Bug #1456589 reported by
Colin Watson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
<wgrant> cjwatson: Ah, hm. Git MPs live under their target ref, but their target ref may no longer exist.
<wgrant> eg. the launchpad:test MP on https:/
It would make sense to move these directly under GitRepository, and it would make the URLs a bit less obnoxious. We'll need to leave redirects behind.
Related branches
lp:~cjwatson/launchpad/git-mp-move-outside-ref
- William Grant: Approve (code)
-
Diff: 260 lines (+76/-15)13 files modifiedlib/lp/code/browser/branch.py (+1/-3)
lib/lp/code/browser/configure.zcml (+1/-1)
lib/lp/code/browser/gitref.py (+5/-3)
lib/lp/code/browser/gitrepository.py (+11/-0)
lib/lp/code/interfaces/branch.py (+3/-0)
lib/lp/code/interfaces/branchmergeproposal.py (+4/-0)
lib/lp/code/interfaces/gitref.py (+3/-0)
lib/lp/code/interfaces/gitrepository.py (+3/-0)
lib/lp/code/model/branch.py (+7/-0)
lib/lp/code/model/branchmergeproposal.py (+7/-0)
lib/lp/code/model/gitref.py (+4/-0)
lib/lp/code/model/gitrepository.py (+4/-0)
lib/lp/code/model/tests/test_branchmergeproposal.py (+23/-8)
| tags: | added: 404 |
| Changed in launchpad: | |
| assignee: | nobody → Colin Watson (cjwatson) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r17527 <http://