Please add support for +activereviews for git branches
Bug #1453020 reported by
Michael Vogt
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
Its fantastic that we have git support now in launchpad!
One missing piece appears to be that the +activereviews page is not implmented yet. E.g. on
https:/
there is a link to
https:/
which will give me a OOPs.
As discussed on irc here is a bugreport :)
Related branches
lp:~cjwatson/launchpad/git-activereviews
- William Grant: Approve (code)
-
Diff: 951 lines (+349/-104)10 files modifiedlib/lp/code/browser/branchmergeproposallisting.py (+18/-24)
lib/lp/code/browser/configure.zcml (+6/-0)
lib/lp/code/browser/tests/test_branchmergeproposallisting.py (+206/-60)
lib/lp/code/interfaces/gitref.py (+2/-1)
lib/lp/code/interfaces/hasbranches.py (+20/-5)
lib/lp/code/model/branchmergeproposal.py (+25/-7)
lib/lp/code/model/gitcollection.py (+15/-0)
lib/lp/code/model/hasbranches.py (+53/-3)
lib/lp/code/templates/branchmergeproposal-listing.pt (+2/-2)
lib/lp/code/templates/branchmergeproposal-macros.pt (+2/-2)
| tags: | added: 404 git ui |
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | nobody → Colin Watson (cjwatson) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r17500 <http://