Launchpad itself

updateContentsFiles doesn't check for suite immutability

Bug #1448270 reported by William Grant on 2015-04-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
​ Launchpad itself
Fix Released
Critical
Colin Watson
Also affects project (?) Also affects distribution/package Nominate for series

Bug Description

PublishFTPMaster.updateContentsFiles can update Contents files for immutable suites, leading to the checksums in Release being incorrect. Long-term we may want a mode that just updates Release without rebuilding Packages and Sources, but for now we should just forbid Contents copies into immutable suites.

Related branches

lp:~cjwatson/launchpad/immutable-contents
William Grant: Approve (code) on 2015-09-25
Diff: 229 lines (+71/-21)
6 files modified
lib/lp/archivepublisher/publishing.py (+10/-8)
lib/lp/archivepublisher/scripts/generate_contents_files.py (+6/-0)
lib/lp/archivepublisher/scripts/publish_ftpmaster.py (+6/-1)
lib/lp/archivepublisher/scripts/publishdistro.py (+3/-2)
lib/lp/archivepublisher/tests/test_generate_contents_files.py (+25/-9)
lib/lp/archivepublisher/tests/test_publish_ftpmaster.py (+21/-1)
Colin Watson (cjwatson) on 2015-04-24
Changed in launchpad:
assignee: nobody → Colin Watson (cjwatson)
Colin Watson (cjwatson) on 2015-09-23
Changed in launchpad:
status: Triaged → Fix Committed
status: Fix Committed → In Progress
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17757 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17757>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Colin Watson (cjwatson) on 2015-09-25
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant) on 2015-09-29
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.
Subscribing...

Other bug subscribers