Some displayed sourcepackagerelease changes files don't have attribution

Bug #144620 reported by William Grant
10
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
High
Unassigned

Bug Description

Take https://edge.launchpad.net/ubuntu/+source/gnome-build/+changelog for example. The entries for 0.2.0-2 and 0.1.7-1~feisty1 don't have attribution lines, 0.1.7-1, 0.1.6-0ubuntu1 and 0.1.5-1 do, while 0.1.3-2 again doesn't.

Tags: lp-soyuz
James Troup (elmo)
Changed in soyuz:
status: New → Confirmed
Revision history for this message
LaserJock (laserjock) wrote :

This is a rather annoying bug. Finding out *who* made a change is essential if the source page is to be taken seriously for packaging work. +publishinghistory doesn't help either.

Celso Providelo (cprov)
Changed in soyuz:
importance: Undecided → High
status: Confirmed → Triaged
Revision history for this message
William Grant (wgrant) wrote :

The changelog entries displayed are taken from the changes file, cut off at the start of the second changelog entry. This results in any multi-entry changes files lacking the author line. The function that does this is SourcePackageRelease.change_summary().

Perhaps it would be better to always show just the first entry, rendering the author some other way.

Revision history for this message
Celso Providelo (cprov) wrote :

Yes, SPR.change_summary() isn't needed anymore since SPR.changelog_entry is supposed to contain *only* the last changelog entry as mentioned in the original upload .changes files.

OTOH, I wonder if we should changelog entries like http://launchpadlibrarian.net/9463784/gnome-build_0.2.0-2_source.changes produce any benefit (it's just a copy and paste of a synced chunk of changelog not assigned to their authors individually).

I believe the best we can do is to bypass SPR.changes_summary() (actually remove it since it's not needed at all) as suggested by Willian and possibly blame the uploader for inconsistent changelog entries when it's the case.

Revision history for this message
William Grant (wgrant) wrote :

Note that it is current Ubuntu policy to specify -v when doing merges/syncs -- we are explicitly told to include those extra changelog entries from Debian.

William Grant (wgrant)
description: updated
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.