Allow Git repository subscriptions
Bug #1444591 reported by
Colin Watson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
It should be possible to subscribe to natively-hosted Git repositories, just as it is possible to subscribe to Bazaar branches. This is more or less a prerequisite for merge proposals (it would be possible to implement them without this, but it doesn't seem to be worth the effort to avoid subscriptions).
Related branches
lp:~cjwatson/launchpad/db-git-subscriptions
- William Grant (community): Approve (db)
- Stuart Bishop: Pending (db) requested
-
Diff: 82 lines (+39/-0)2 files modifieddatabase/schema/patch-2209-61-4.sql (+32/-0)
database/schema/security.cfg (+7/-0)
lp:~cjwatson/launchpad/git-subscriptions
- William Grant (community): Approve (code)
-
Diff: 1305 lines (+813/-42)26 files modifiedlib/lp/_schema_circular_imports.py (+4/-0)
lib/lp/code/configure.zcml (+9/-0)
lib/lp/code/interfaces/branch.py (+1/-1)
lib/lp/code/interfaces/branchsubscription.py (+1/-1)
lib/lp/code/interfaces/gitcollection.py (+4/-0)
lib/lp/code/interfaces/gitrepository.py (+82/-0)
lib/lp/code/interfaces/gitsubscription.py (+99/-0)
lib/lp/code/interfaces/webservice.py (+2/-0)
lib/lp/code/model/branchnamespace.py (+4/-4)
lib/lp/code/model/gitcollection.py (+9/-0)
lib/lp/code/model/gitnamespace.py (+17/-0)
lib/lp/code/model/gitrepository.py (+105/-6)
lib/lp/code/model/gitsubscription.py (+71/-0)
lib/lp/code/model/tests/test_branchsubscription.py (+1/-1)
lib/lp/code/model/tests/test_gitcollection.py (+53/-3)
lib/lp/code/model/tests/test_gitrepository.py (+1/-1)
lib/lp/code/model/tests/test_gitsubscription.py (+201/-0)
lib/lp/code/security.py (+27/-0)
lib/lp/registry/browser/tests/private-team-creation-views.txt (+10/-2)
lib/lp/registry/doc/private-team-roles.txt (+31/-1)
lib/lp/registry/model/person.py (+3/-0)
lib/lp/registry/model/sharingjob.py (+24/-5)
lib/lp/registry/personmerge.py (+21/-3)
lib/lp/registry/services/tests/test_sharingservice.py (+1/-3)
lib/lp/registry/tests/test_sharingjob.py (+19/-11)
lib/lp/testing/factory.py (+13/-0)
lp:~cjwatson/launchpad/git-subscriptions-personmerge-whitelist
- Colin Watson (community): Approve
-
Diff: 13 lines (+3/-0)1 file modifiedlib/lp/registry/personmerge.py (+3/-0)
lp:~cjwatson/launchpad/git-mail
- William Grant (community): Approve (code)
-
Diff: 1151 lines (+500/-95)16 files modifiedlib/lp/code/adapters/branch.py (+4/-5)
lib/lp/code/adapters/gitrepository.py (+52/-0)
lib/lp/code/configure.zcml (+6/-0)
lib/lp/code/doc/branch-notifications.txt (+6/-6)
lib/lp/code/interfaces/branch.py (+6/-0)
lib/lp/code/interfaces/branchmergeproposal.py (+10/-0)
lib/lp/code/interfaces/gitref.py (+45/-0)
lib/lp/code/interfaces/gitrepository.py (+27/-0)
lib/lp/code/mail/branch.py (+47/-20)
lib/lp/code/mail/branchmergeproposal.py (+4/-4)
lib/lp/code/mail/tests/test_branch.py (+171/-49)
lib/lp/code/model/branchjob.py (+4/-4)
lib/lp/code/model/branchmergeproposal.py (+13/-1)
lib/lp/code/model/gitref.py (+90/-5)
lib/lp/code/model/gitrepository.py (+14/-0)
lib/lp/code/model/tests/test_gitrepository.py (+1/-1)
lp:~cjwatson/launchpad/git-subscriptions-browser
- William Grant (community): Approve (code)
-
Diff: 785 lines (+660/-5)12 files modifiedlib/lp/code/browser/configure.zcml (+44/-0)
lib/lp/code/browser/gitrepository.py (+19/-1)
lib/lp/code/browser/gitsubscription.py (+293/-0)
lib/lp/code/browser/tests/test_gitsubscription.py (+58/-0)
lib/lp/code/interfaces/gitsubscription.py (+1/-1)
lib/lp/code/model/gitrepository.py (+3/-2)
lib/lp/code/model/tests/test_gitrepository.py (+111/-1)
lib/lp/code/templates/gitrepository-edit-subscription.pt (+45/-0)
lib/lp/code/templates/gitrepository-index.pt (+1/-0)
lib/lp/code/templates/gitrepository-portlet-subscribers-content.pt (+31/-0)
lib/lp/code/templates/gitrepository-portlet-subscribers.pt (+29/-0)
lib/lp/code/templates/gitsubscription-edit.pt (+25/-0)
lp:~cjwatson/launchpad/git-mail-fix-delta
- William Grant (community): Approve (code)
-
Diff: 311 lines (+157/-17)6 files modifiedlib/lp/code/adapters/gitrepository.py (+6/-4)
lib/lp/code/adapters/tests/test_gitrepository.py (+53/-0)
lib/lp/code/interfaces/gitrepository.py (+12/-3)
lib/lp/code/model/gitnamespace.py (+10/-6)
lib/lp/code/model/gitrepository.py (+4/-0)
lib/lp/code/model/tests/test_gitrepository.py (+72/-4)
| Changed in launchpad: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Colin Watson (cjwatson) |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Colin Watson (cjwatson) wrote | #3 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #4 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #5 |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #6 |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #7 |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
r17430 in stable (http://