existing /var/tmp/fatsam.test breaks the test suite

Bug #1433 reported by Christian Reis on 2005-07-13
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Low
Andrew Bennetts

Bug Description

We're getting serious PQM downtime because of failures in the test suite caused by the fact that a fatsam.test directory already exists.

It may make sense to stop using a hardcoded directory and instead generate the name.

Stuart Bishop (stub) wrote :

We can't generate the name due to the mechanics of the config system (the path is read from the config file, not generated at runtime, and changing this would introduce a whole host of other issues such as how to tell the suprocess what it should be using, how to test that read-from-the-config file actually works when the test suites don't do that, etc.)

The LibrianTestSetup should nuke it if it exists.

Dafydd Harries (daf) wrote :

At a glance, this hasn't been fixed yet. Whose job is it?

Dafydd Harries (daf) wrote :

Stuart says it doesn't happen very often, which means that it's not a particularly high priority.

Changed in launchpad:
status: New → Accepted
Dafydd Harries (daf) wrote :

Plus, the fact that PQM now runs tests in a chroot should prevent it from happening altogether.

Brad Bollenbach (bradb) wrote :

I thought spiv said he'd look into this. spiv?

Steve Alexander (stevea) on 2006-01-26
Changed in launchpad:
assignee: nobody → spiv
Andrew Bennetts (spiv) wrote :

I believe this part of LibrarianTestSetup means this was already fixed:

    def setUpRoot(self):
        if os.path.isdir(self.root):
            shutil.rmtree(self.root)
        os.makedirs(self.root, 0700)

Changed in launchpad:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers