Bad Notification text after changing email subscriptions
Bug #1425649 reported by
Thomi Richards
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
After subscribing or ubsubscribing to mailing lists via +editemails, the notification message on the next page is:
"Your auto-subscribe policy has been updated"
even though I didn't change the auto-subscribe options on that page.
The notification message should be intelligent enough to figure out what the user changed. Perhaps a range of messages could be used, such as:
"Your mailing list subscriptions have been updated"
or
"Your auto-subscribe policy has been updated"
or
"Your mailing list subscriptions and auto-subscribe policy have been updated"
Related branches
lp:~thomir-deactivatedaccount/launchpad/devel-fix-editemails-link
- William Grant: Approve (code)
-
Diff: 778 lines (+286/-190)14 files modifiedlib/lp/registry/browser/configure.zcml (+6/-0)
lib/lp/registry/browser/person.py (+144/-88)
lib/lp/registry/browser/tests/test_person.py (+7/-0)
lib/lp/registry/doc/teammembership-email-notification.txt (+2/-2)
lib/lp/registry/mail/notification.py (+2/-2)
lib/lp/registry/stories/mailinglists/subscriptions.txt (+17/-17)
lib/lp/registry/stories/person/xx-person-home.txt (+3/-1)
lib/lp/registry/stories/team/xx-team-membership.txt (+1/-1)
lib/lp/registry/templates/person-editemails.pt (+4/-73)
lib/lp/registry/templates/person-editmailinglists.pt (+86/-0)
lib/lp/registry/templates/person-participation.pt (+1/-1)
lib/lp/registry/templates/person-portlet-contact-details.pt (+11/-3)
lib/lp/registry/templates/team-portlet-mailinglist.pt (+1/-1)
lib/lp/registry/tests/test_mailinglist.py (+1/-1)
| Changed in launchpad: | |
| assignee: | nobody → Thomi Richards (thomir) |
| status: | New → In Progress |
Revision history for this message
| Thomi Richards (thomir-deactivatedaccount) wrote | #1 |
| Changed in launchpad: | |
| importance: | Undecided → Low |
| tags: | added: confusing-ui mailing-lists |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Upon further investigation here, the issue is that it's very easy to click the wrong button on +editemails, which results in your settings not being saved.