Launchpad itself

LibraryFileAliasSet.create thinks all IntegrityErrors mean that the filename contains slashes

Bug #1422207 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
William Grant

Bug Description

LibraryFileAliasSet.create squashes any IntegrityError from addFile into an InvalidFilename exception. But there may be unflushed changes that can fail in different ways, or some unexpected failure inside addFile.

Related branches

lp:~wgrant/launchpad/couple-of-oopses
Colin Watson (community): Approve
Diff: 62 lines (+12/-6)
3 files modified
lib/lp/buildmaster/model/buildfarmjobbehaviour.py (+7/-2)
lib/lp/services/librarian/model.py (+2/-4)
lib/lp/services/librarianserver/swift.py (+3/-0)
William Grant (wgrant)
Changed in launchpad:
assignee: nobody → William Grant (wgrant)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17342 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17342>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.