Launchpad itself

buildd-manager can repeatedly upload builds if handleStatus fails in the wrong place

Bug #1422199 reported by William Grant on 2015-02-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
​ Launchpad itself
Fix Released
Critical
William Grant
Also affects project (?) Also affects distribution/package Nominate for series

Bug Description

If BuildFarmJobBehaviourBase.handleStatus fails between self.handleSuccess and transaction.commit, the upload directory can be left in the queue without the build status changing. The next buildd-manager iteration then uploads it to the queue again, resulting in "2015-02-15 22:39:10 WARNING Expected build status to be 'UPLOADING', was FULLYBUILT. Ignoring.".

This is most often seen when a network glitch causes storeLogFromSlave to fail. It can probably be largely mitigating by storing the log first.

See original description

Related branches

lp:~wgrant/launchpad/couple-of-oopses
Colin Watson: Approve on 2015-02-16
Diff: 62 lines (+12/-6)
3 files modified
lib/lp/buildmaster/model/buildfarmjobbehaviour.py (+7/-2)
lib/lp/services/librarian/model.py (+2/-4)
lib/lp/services/librarianserver/swift.py (+3/-0)
William Grant (wgrant) on 2015-02-15
Changed in launchpad:
assignee: nobody → William Grant (wgrant)
status: Triaged → In Progress
William Grant (wgrant) on 2015-02-15
description: updated
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17342 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17342>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant) on 2015-02-19
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant) on 2015-02-20
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.
Subscribing...

Other bug subscribers