Librarian requests occasionally fail: 'NoneType' object has no attribute 'get_object'
Bug #1420046 reported by
William Grant
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Colin Watson |
Bug Description
Roughly 25 Swift Librarian requests fail each day like OOPS-f1c692cf8f319c390c1a8940f8187009:
Unhandled Error
Traceback (most recent call last):
Failure: exceptions.
Possibly the Swift connection pool ends up with a None in it?
Related branches
lp:~cjwatson/launchpad/librarian-swift-assertion-errors
- William Grant (community): Approve (code)
-
Diff: 302 lines (+126/-76)4 files modifiedlib/lp/services/librarianserver/storage.py (+4/-16)
lib/lp/services/librarianserver/swift.py (+4/-2)
lib/lp/services/librarianserver/tests/test_storage.py (+1/-46)
lib/lp/services/librarianserver/tests/test_storage_db.py (+117/-12)
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Colin Watson (cjwatson) |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
An assert in ConnectionPool.put will locate anywhere that does this. Or log the traceback and throw the None away.