Failed build email is misleading over control file lists section

[David Morris]

Since a fullstop is placed at the end of the line "22:37:36 WARNING opensg_1.8.0alpha1~ppa4_amd64.deb control file lists section as universe/misc. but changes file has universe/misc." the user can easily be lead to believe (as I was) that a full stop is required on the line in the control file

 * Source Package: opensg
 * Version: 1:1.8.0alpha1~ppa4
 * Architecture: amd64
 * Archive: dave-greenacre PPA
 * State: Failed to upload
 * Duration: 41 minutes
 * Build Log: http://launchpadlibrarian.net/9274481/buildlog_ubuntu-feisty-amd64.opensg_1%3A1.8.0alpha1%7Eppa4_BUILDING.txt.gz
 * Builder: https://launchpad.net/+builds/promethium
 * Source: not available

Upload log:
22:37:31 INFO creating lockfile
22:37:35 DEBUG Initialising connection.
22:37:35 DEBUG Beginning processing
22:37:35 DEBUG Checked in /srv/launchpad.net/builddmaster/incoming, found ['20070913-233730-388280-960380']
22:37:35 DEBUG Considering upload 20070913-233730-388280-960380
22:37:35 DEBUG Considering changefile ~dave-greenacre/ubuntu/opensg_1.8.0alpha1~ppa4_amd64.changes
22:37:35 DEBUG Finding fresh policy
22:37:35 DEBUG Changes file can be unsigned.
22:37:35 INFO Processing upload opensg_1.8.0alpha1~ppa4_amd64.changes
22:37:35 DEBUG Beginning processing.
22:37:35 WARNING Unable to grok section 'misc.', overriding it with misc
22:37:35 DEBUG Verifying the changes file.
22:37:35 DEBUG Verifying files in upload.
22:37:35 DEBUG Verifying binary opensg_1.8.0alpha1~ppa4_amd64.deb
22:37:35 DEBUG Verifying timestamps in opensg_1.8.0alpha1~ppa4_amd64.deb
22:37:36 DEBUG No signer, therefore ACL not processed
22:37:36 DEBUG Do verify signer ACL for PPA
22:37:36 DEBUG Finished checking upload.
22:37:36 WARNING Upload was rejected:
22:37:36 WARNING opensg_1.8.0alpha1~ppa4_amd64.deb control file lists section as universe/misc. but changes file has universe/misc.
22:37:36 INFO Committing the transaction and any mails associated with this upload.
22:37:36 DEBUG Moving upload directory /srv/launchpad.net/builddmaster/incoming/20070913-233730-388280-960380 to /srv/launchpad.net/builddmaster/rejected/20070913-233730-388280-960380
22:37:36 DEBUG Rolling back any remaining transactions.
22:37:36 DEBUG Removing lock file: /var/lock/process-upload-buildd.lock

If you want further information about this situation, feel free to
contact a member of the Launchpad Buildd Administrators team.

--
amd64 build of opensg 1:1.8.0alpha1~ppa4 in ubuntu feisty RELEASE
https://launchpad.net/~dave-greenacre/+archive/+build/388280

[Vikram Dhillon (dhillon-v10)]

@Julian: Any idea where I can find this email template in the code, the folder email templates doesn't contain anything besides the __init__.py. Its a pretty easy bug, just remove the full stop :)

[Michael Nelson (michael.nelson)]

@Vikram (Just saving Julian a bit of work ;)), it'

[Michael Nelson (michael.nelson)]

it's not in an email template... you'll find the actual extra full-stop in lib/lp/archiveuploader/nascentuploadfile.py in BaseBinaryUploadFile.verifyProperty()

Thanks for fixing it! (make sure you run the nascentuploadfile.txt test too).

[Julian Edwards (julian-edwards)]

Vikram, you can run the test with:

bin/test -cvvt nascentuploadfile.txt

[Colin Watson (cjwatson)]

Rather than removing the full stop, let's instead put quotes around the two section names.