Contents generation races with publisher
Bug #1384797 reported by
Colin Watson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
We've observed a number of cases where Contents generation appears to race with the publisher. This is because updateContentsFile installs the new Contents file directly into the target dists/ directory; if the publisher happens to be running at the time, then it will have taken a copy of dists/ already and will move it into place at the end of its run, and will thus discard the updated Contents files.
We should instead arrange for Contents generation to place the updated file in a known location which the publisher picks up.
Related branches
lp:~cjwatson/launchpad/contents-race
- William Grant: Approve (code)
-
Diff: 391 lines (+158/-33)7 files modifiedlib/lp/archivepublisher/scripts/generate_contents_files.py (+5/-17)
lib/lp/archivepublisher/scripts/publish_ftpmaster.py (+43/-1)
lib/lp/archivepublisher/tests/test_generate_contents_files.py (+11/-10)
lib/lp/archivepublisher/tests/test_publish_ftpmaster.py (+72/-1)
lib/lp/registry/interfaces/distribution.py (+4/-1)
lib/lp/registry/model/distribution.py (+7/-1)
lib/lp/registry/tests/test_distribution.py (+16/-2)
| Changed in launchpad: | |
| assignee: | nobody → Colin Watson (cjwatson) |
| status: | Triaged → In Progress |
| importance: | Low → High |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r17341 <http://