Launchpad itself

createMissingBuilds misbehaves when copying between series with different nominatedarchindep

Bug #1350208 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
William Grant

Bug Description

createMissingBuilds creates new nominatedarchindep builds for arch-indep sources if there are no existing binaries built in a DAS with the nominatedarchindep's archtag. This is fine when nominatedarchindep is consistent between the involved series, but breaks down if it changes: if I copy an arch-indep-only source+binary that was built on i386 to a series where nominatedarchindep is amd64, I'll get a new amd64 build that will fail to upload.

Related branches

lp:~wgrant/launchpad/bpb-arch_indep-db
William Grant: Approve (db)
Diff: 12 lines (+8/-0)
1 file modified
database/schema/patch-2209-59-0.sql (+8/-0)
lp:~wgrant/launchpad/bpb-arch_indep-2
William Grant: Approve (code)
Diff: 169 lines (+23/-47)
6 files modified
database/schema/security.cfg (+0/-1)
lib/lp/scripts/garbo.py (+0/-35)
lib/lp/scripts/tests/test_garbo.py (+1/-4)
lib/lp/soyuz/model/binarypackagebuildbehaviour.py (+1/-5)
lib/lp/soyuz/tests/test_binarypackagebuildbehaviour.py (+16/-0)
lib/lp/testing/factory.py (+5/-2)
lp:~wgrant/launchpad/bpb-arch_indep
William Grant: Approve (codew)
Diff: 218 lines (+80/-7)
7 files modified
database/schema/security.cfg (+1/-0)
lib/lp/scripts/garbo.py (+32/-0)
lib/lp/scripts/tests/test_garbo.py (+21/-1)
lib/lp/soyuz/interfaces/binarypackagebuild.py (+7/-1)
lib/lp/soyuz/model/binarypackagebuild.py (+7/-4)
lib/lp/soyuz/model/distroarchseries.py (+1/-1)
lib/lp/soyuz/tests/test_build_set.py (+11/-0)
lp:~wgrant/launchpad/bpb-arch_indep-db-2
William Grant: Approve (db)
Diff: 150 lines (+71/-48)
4 files modified
database/sampledata/current-dev.sql (+24/-24)
database/sampledata/current.sql (+24/-24)
database/schema/patch-2209-59-1.sql (+15/-0)
database/schema/patch-2209-59-2.sql (+8/-0)
lp:~wgrant/launchpad/bpb-arch_indep-garbo-state (Merged)
lp:~wgrant/launchpad/bpb-arch_indep-new (Merged)
lp:~wgrant/launchpad/simplify-getRelevantToSourceAndArchive
William Grant: Approve (code)
Diff: 725 lines (+140/-496)
6 files modified
lib/lp/soyuz/doc/sourcepackagerelease-build-lookup.txt (+0/-349)
lib/lp/soyuz/interfaces/binarypackagebuild.py (+9/-8)
lib/lp/soyuz/model/binarypackagebuild.py (+38/-87)
lib/lp/soyuz/scripts/tests/test_initialize_distroseries.py (+2/-2)
lib/lp/soyuz/tests/test_build_set.py (+91/-46)
lib/lp/soyuz/tests/test_doc.py (+0/-4)
lp:~wgrant/launchpad/bug-1350208
William Grant: Approve (code)
Diff: 308 lines (+181/-50)
4 files modified
lib/lp/soyuz/adapters/buildarch.py (+2/-2)
lib/lp/soyuz/adapters/tests/test_buildarch.py (+1/-1)
lib/lp/soyuz/model/binarypackagebuild.py (+75/-47)
lib/lp/soyuz/tests/test_build_set.py (+103/-0)
William Grant (wgrant)
summary: - createMissingBuilds misbehves when copying between series with different
- nominatedarchindep
+ createMissingBuilds misbehaves when copying between series with
+ different nominatedarchindep
William Grant (wgrant)
Changed in launchpad:
assignee: nobody → William Grant (wgrant)
William Grant (wgrant)
Changed in launchpad:
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r12819 in db-stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/12819) is part of this bug's fix.

tags: added: qa-needstesting
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Changed in launchpad:
importance: Low → Critical
Revision history for this message
William Grant (wgrant) wrote :

2014-11-03 06:10:27,057 INFO 2209-59-0 applied just now in 0.0 seconds

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17221 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17221) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r12824 in db-stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/12824) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Revision history for this message
William Grant (wgrant) wrote :

2209-59-1 manually added to LDR on prod (since garbo did the migration for us), and 2209-59-2 worked fine on staging.

tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17227 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17227) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17229 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17229) is part of this bug's fix.

William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17231 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17231>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.