mails reporting inline diff comments are too verbose
Bug #1334577 reported by
Nick Moffitt
on 2014-06-26
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Launchpad itself |
High
|
Kit Randel | ||
Bug Description
If a MP has a large diff spanning multiple hunks in multiple files, and I add an inline comment in one line in the middle, the corresponding mail contains the entire diff broken at the point where I made my comment.
Could we perhaps have those mails limit the quoted matter to just the hunk above (or surrounding) the comment?
Related branches
lp:~blr/launchpad/bug-1334577-verbose-diff
- Colin Watson: Approve on 2015-06-29
- William Grant: Needs Fixing on 2014-12-05
-
Diff: 379 lines (+208/-55)3 files modifiedlib/lp/code/mail/codereviewcomment.py (+87/-13)
lib/lp/code/mail/tests/test_codereviewcomment.py (+120/-41)
versions.cfg (+1/-1)
William Grant (wgrant)
on 2014-06-26
| Changed in launchpad: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| assignee: | nobody → Chris Johnston (cjohnston) |
| tags: | added: code-review inline-comments |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
William Grant (wgrant)
on 2014-12-01
| Changed in launchpad: | |
| assignee: | Chris Johnston (cjohnston) → nobody |
| status: | In Progress → Triaged |
Kit Randel (blr)
on 2014-12-01
| tags: | added: email |
| Launchpad QA Bot (lpqabot) wrote : | #1 |
| Changed in launchpad: | |
| assignee: | nobody → Bayard 'kit' Randel (blr) |
| tags: | added: qa-untestable |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
William Grant (wgrant)
on 2015-07-01
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r17590 (http://