mails reporting inline diff comments are too verbose

Bug #1334577 reported by Nick Moffitt
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Kit Randel

Bug Description

If a MP has a large diff spanning multiple hunks in multiple files, and I add an inline comment in one line in the middle, the corresponding mail contains the entire diff broken at the point where I made my comment.

Could we perhaps have those mails limit the quoted matter to just the hunk above (or surrounding) the comment?

Related branches

William Grant (wgrant)
Changed in launchpad:
importance: Undecided → High
status: New → Triaged
assignee: nobody → Chris Johnston (cjohnston)
tags: added: code-review inline-comments
Changed in launchpad:
status: Triaged → In Progress
William Grant (wgrant)
Changed in launchpad:
assignee: Chris Johnston (cjohnston) → nobody
status: In Progress → Triaged
Kit Randel (blr)
tags: added: email
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17590 (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17590) by a commit, but not testable.

Changed in launchpad:
assignee: nobody → Bayard 'kit' Randel (blr)
tags: added: qa-untestable
Changed in launchpad:
status: Triaged → Fix Committed
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.