Merge proposers are given review type option which can lead to confusion
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
New
|
Undecided
|
Unassigned | ||
Bug Description
Common workflow:
1. Developer submits a merge proposal
2. Reviewer makes request in comment on MP and sets their review to "Needs fixing"
3. Developer responds to request with comment.
In step 3 the developer is presented with a text field for their comment which has two fields below it "Review" and "Review type". These fields don't seem appropriate for a proposer (since there isn't much point reviewing their own proposal - surely they approve it??) and having them there invites people to do that by accident.
For example, a user might disagree with the request and set it to "disapprove" or they might think it should be set to "resubmit" if their code should be re-reviewed.
I propose hiding these fields when the merge proposal page is viewed by the merge proposer. If they did need to review their own code for some reason they can by choosing "Request another review" at the top of the page.
An example of a user reviewing their own code by mistake:
https:/
