some upload branches fail to be mirrored promptly

[Michael Hudson-Doyle]

I've just been chatting with a user in #bzr who pushed to a branch on launchpad but found that the branch page and the http:// access to the branch didn't reflect the push, and there have been reports of this in the past.

The simplest explanation seems to be that mirror_request_time isn't being set on the branch, but I don't know how that could come to pass.

[Michael Hudson-Doyle (mwhudson)]

This seems like jml territory.

[Alexander Sack (asac)]

I pushed https://code.launchpad.net/~asac/network-manager/ubuntu.0.6.x.dev from rev 37 up to rev 43 ... and mirroring failed.

I uploaded between Fri 2007-08-03 13:07:32 +0000 and 13:12:00 iirc

i used sftp ... my lp id is 'asac'

[Alexander Sack (asac)]

ah ... i used bzr 0.18 iirc

[Alexander Sack (asac)]

ah ... i used bzr 0.18-1 iirc

[Tim Penhey (thumper)]

A race condition was noticed during the implementation of another feature, and I think that it fixes this problem.

[Jonathan Lange (jml)]

We don't have enough information to construct a test that reproduces this bug, however the race condition that thumper noted seems likely to be the cause.

A fix is in the branch that fixes bug 74031. Unfortunately, this branch just missed getting into the 1.1.8 release.

[Jonathan Lange (jml)]

Need more info to diagnose this bug. Should get more information once bug 133632 is fixed and released.

[Jonathan Lange (jml)]

Bug 133632 (access logs) is moving along nicely. Let's try to fix this in 1.10!

[Jonathan Lange (jml)]

I *think* the fix for bug 132873 fixes this, but that's only a guess. I'll ask Tom to let me have a look at the codehosting access logs so I can do a proper diagnosis.

[Jonathan Lange (jml)]

Still need to look at the logs.

I'm keen to know if this bug is still occurring.

[David Allouche (ddaa)]

We haven't had any complaint about it since 1.1.9.

If we do not get any complaint until 1.1.11, I think we can mark it "fix released in 1.1.9".

[Jonathan Lange (jml)]

Released in 1.1.9 by linking mirroring to unlocking, rather than client disconnect.