soyuz emails lack X-LP-Message-Rationale

[Ian Jackson]

I'm a member of ubuntu-sponsors-main. Being a member of this team is necessary for me to help out as a sponsor. This means I get a lot of unwanted mail. I filter this mail out, using the X-Launchpad-Message-Rationale header.

I just received two emails from soyuz which AFAICT were sent because in each case I approved a sync request (in my capacity as a sponsor) and therefore my name was in the Changed-By field.

This was quite confusing. Note that sponsors are probably doing other things too and may not remember all of the relevant package names from a few days ago.

It would be nice if
 * There was an X-LP-M-R header
 * It was clear that the Changed-By was synthetic in that all I did was request a sync

[Matthew Paul Thomas (mpt)]

Could you attach one of these e-mail messages to the bug report?

[Ian Jackson (ijackson)]

Matthew Paul Thomas writes ("[Bug 127917] Re: soyuz emails lack X-LP-Message-Rationale"):
> Could you attach one of these e-mail messages to the bug report?

Here is one. I have uuencoded it and pasted it in here rather than
using multipart/mixed containing message/rfc822 because I don't trust
Malone to deal properly with the latter.

begin 664 email.mbox
M1G)O;2!632!4=64@2G5L(#(T(#$Q.C`P.C(S(#(P,#<*6"U632UV-2U$871A
M.B`H6VYI;"!N:6P@;FEL(&YI;"!N:6P@;FEL(&YI;"!N:6P@;FEL70H)6VYI
M;"`B5'5E<V1A>2(@(C(T(B`B2G5L>2(@(C(P,#<B("(P.3HT-SHR-R(@(BTP
M,#`P(B`B56)U;G1U($EN<W1A;&QE<B(@(F%R8VAI=F5`=6)U;G1U+F-O;2(@
M;FEL(&YI;"`B06-C97!T960@;&%P=&]P+61E=&5C="`P+C$S+C(@*'-O=7)C
M92DB(")>1G)O;3HB(&YI;"!N:6P@(C<B(&YI;"!N:6P@*&YU;6)E<B`B("`@
M("`@,C0@2G5L>2`@56)U;G1U($EN<W1A;&QE<B`@("`@06-C97!T960@;&%P
M=&]P+61E=&5C="`P+C$S+C(@*'-O=7)C92E<;B(I(&YI;"!N:6P@;FEL(&YI
M;"!N:6Q="@EN:6PI"E)E8V5I=F5D.B!F<F]M("AC:&EA<FLN9W)E96YE;F0N
M;W)G+G5K*2!;,3<R+C,Q+C@P+CA=(`H)8GD@9&%V96YA;G0N9W)E96YE;F0N
M;W)G+G5K('=I=&@@97-M='`@*$5X:6T@,RXS-B`C,2D*"6ED(#%)1$=Z5"TP
M,#`R1#$M,#`@*$1E8FEA;BD[(%1U92P@,C0@2G5L(#(P,#<@,3`Z-#<Z,SD@
M*S`Q,#`*4F5C96EV960Z(&9R;VT@9FEO<F1L86YD+G5B=6YT=2YC;VT@*%LX
M,BXR,3$N.#$N,30U72D*"6)Y(&-H:6%R:RYG<F5E;F5N9"YO<F<N=6L@*$1E
M8FEA;B!%>&EM(#,N,S8@(S$I('=I=&@@97-M='`*"2AR971U<FXM<&%T:"!B
M;W5N8V5S0&-A;F]N:6-A;"YC;VTI"@EI9"`Q241'>E0M,#`P,$-5+3`P"@EF
M;W(@(R,C(R-`8VAI87)K+F=R965N96YD+F]R9RYU:SL@5'5E+"`R-"!*=6P@
M,C`P-R`Q,#HT-SHS.2`K,#$P,`I296-E:79E9#H@9G)O;2!F:6]R9&QA;F0N
M=6)U;G1U+F-O;2`H6S@R+C(Q,2XX,2XQ-#5=*0H)("!B>2!C:&EA<FLN9W)E
M96YE;F0N;W)G+G5K("A3055#12!V,"XX+CDY+FEW:BXU*0H@("`@("`@("`@
M=VET:"!E<VUT<"!I9"!S875C92TU-3@R+3$Q.#4R-S`M,3L@,C0@2G5L(#(P
M,#<@,#DZ-#<Z,SD@*S`P,#`@*$=-5"D*4F5C96EV960Z(&9R;VT@8VQU<W1E
M<BUJ+FUA:6QC;VYT<F]L+F-O;2`H8VQU<W1E<BUJ+FUA:6QC;VYT<F]L+F-O
M;2!;.#8N,3$Q+C(R,RXQ.3!=*0H)8GD@9FEO<F1L86YD+G5B=6YT=2YC;VT@
M*%!O<W1F:7@I('=I=&@@15--5%`@:60@-#0Q0C="-C@Q,S<*"69O<B`\(R,C
M(R-`8VQE86YM86EL+F-A;F]N:6-A;"YC;VT^.R!4=64L(#(T($IU;"`R,#`W
M(#$P.C0W.C,T("LP,3`P("A"4U0I"E)E8V5I=F5D.B!F<F]M(&%R8W1O=W-K
M:2YU8G5N='4N8V]M("AA<F-T;W=S:VDN=6)U;G1U+F-O;2!;.#(N,C$Q+C@Q
M+C$U.%TI"@EB>2!R;'DR-VHN<W)V+FUA:6QC;VYT<F]L+F-O;2`H36%I;$-O
M;G1R;VPI('=I=&@@15--5%`@:60@;#9/.6Q3864P,3<S,C$*"69O<B`\(R,C
M(R-`8VQE86YM86EL+F-A;F]N:6-A;"YC;VT^.R!4=64L(#(T($IU;"`R,#`W
M(#$P.C0W.C(Y("LP,3`P"E)E8V5I=F5D.B!F<F]M(&9I;W)D;&%N9"YU8G5N
M='4N8V]M("A;.#(N,C$Q+C@Q+C$T-5TI"@EB>2!A<F-T;W=S:VDN=6)U;G1U
M+F-O;2!W:71H(&5S;71P("A%>&EM(#0N-C`I"@DH96YV96QO<&4M9G)O;2`\
M8F]U;F-E<T!C86YO;FEC86PN8V]M/BD*"6ED(#%)1$=Z22TP,#`Q>%$M-G(*
M"69O<B`C(R,C(T!C;&5A;FUA:6PN8V%N;VYI8V%L+F-O;3L@5'5E+"`R-"!*
M=6P@,C`P-R`Q,#HT-SHR."`K,#$P,`I296-E:79E9#H@9G)O;2!A9&5L:64N
M=6)U;G1U+F-O;2`H861E;&EE+G5B=6YT=2YC;VT@6S@R+C(Q,2XX,2XQ,SE=
M*0H)8GD@9FEO<F1L86YD+G5B=6YT=2YC;VT@*%!O<W1F:7@I('=I=&@@15--
M5%`@:60@13$T.3%"-C@Q,D4*"69O<B`\:7=J0'5B=6YT=2YC;VT^.R!4=64L
M(#(T($IU;"`R,#`W(#$P.C0W.C(W("LP,3`P("A"4U0I"E)E8V5I=F5D.B!F
M<F]M(&1R97-C:&5R+G5B=6YT=2YC;VT@*%LX,BXR,3$N.#$N,38W72D*"6)Y
M(&%D96QI92YU8G5N='4N8V]M('=I=&@@97-M='`@*$5X:6T@-"XV,"`C,2`H
M1&5B:6%N*2D*"6ED(#%)1$=Z2"TP,#`R8DXM45<*"69O<B`\:7=J0'5B=6YT
M=2YC;VT^.R!4=64L(#(T($IU;"`R,#`W(#$P.C0W.C(W("LP,3`P"E)E8V5I
M=F5D.B!F<F]M(&1R97-C:&5R+G5B=6YT=2YC;VT@*&QO8V%L:&...

[Diogo Matsubara (matsubara)]

Is this still valid? I can see that we have a number of headers for soyuz emails. I'm not sure they cover what's requested in this bug report.

Celso, can you confirm?

[Celso Providelo (cprov)]

Yes, this bug is still valid.

Despite of the fact we are redesigning the upload announcement contents in bug 250820, the way we send them (one message to all recipients involved with the upload) makes impossible to set a coherent 'X-Launchpad-Message-Rationale' header.

It will require some efforts in refactoring the current code to allow us to send individual messages with the following rationales:

 * you are subscribed to the distroseries announcement mailisting;
 * you have uploaded this source;
 * you have requested the sync of this source;
 * you have sponsored this source upload;
 * you are the maintainer of this source upload;
 * ...

I'm sure there are more cases, it's not a trivial problem.

[Robert Collins (lifeless)]

(I've dropped this to low to reflect reality: anything that isn't high is not currently 'on the radar'.

[Colin Watson (cjwatson)]

https://code.launchpad.net/~cjwatson/launchpad/bpb-basemailer/+merge/264698 implements this for build notifications, but we still need to do a similar thing for upload notifications.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r17698 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17698>.