Style sheet is overly complex

Bug #126684 reported by Matthew Paul Thomas on 2007-07-18
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Low
Unassigned

Bug Description

Launchpad's style sheet currently is overly complicated:
* some rules are never used (e.g. .notforprint, .notforscreen, .hr)
* some rules are always overridden (e.g. hr, #portlets .portlet)
* there are several XXXs that need proper comments
* there are two conflicting sections for the columns in the normal page layout
* "!important" is overused
* IE6-specific rules are in the style sheet itself, while IE7-specific rules are in the main template
* people have piled on several rules at the end of the style sheet that really should be elsewhere.

Making the style sheet simple reduces debugging problems and makes Launchpad faster.

Style sheet length as of...
r6602: 1887 lines, including 19 uses of "!important".
r6681: 1779 lines, including 8 uses of "!important".
r6715: 1796 lines, including 9 uses of "!important".

description: updated
Changed in launchpad:
assignee: nobody → mpt
importance: Undecided → Medium
Changed in launchpad:
status: New → Confirmed
Changed in launchpad:
status: Confirmed → In Progress
Matthew Paul Thomas (mpt) wrote :

Partly fixed in mainline r4911. Some work left to do.

description: updated
Changed in launchpad:
milestone: 1.1.10 → 1.1.11
Changed in launchpad:
milestone: 1.1.11 → none
description: updated
description: updated
description: updated
description: updated
Curtis Hovey (sinzui) on 2009-12-21
tags: added: css
Changed in launchpad-foundations:
assignee: Matthew Paul Thomas (mpt) → nobody
status: In Progress → Triaged
Jonathan Lange (jml) on 2010-03-12
affects: launchpad-foundations → launchpad-web
Zearin (zearin) wrote :

Kudos to the original poster for helping bring this to attention. This is one kind of thing I wish I saw exposed more often. :)

Robert Collins (lifeless) wrote :

Not currently scheduled - putting in the backlog.

Changed in launchpad:
importance: Medium → Low
Curtis Hovey (sinzui) wrote :

We have dismantled the stylesheet into manage parts. There are vestigial styles in icing/style.css. This bug an be closed when icing/style.css is deleted.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints