Activity log for bug #125637

Date Who What changed Old value New value Message
2007-07-12 20:23:40 Brad Crittenden bug added bug
2007-07-12 20:31:30 Diogo Matsubara launchpad: status New Confirmed
2007-07-12 20:31:30 Diogo Matsubara launchpad: statusexplanation
2007-07-13 21:17:07 Francis J. Lacoste description Many places in our tests we locally define a MockLogger class. There exist two classes in Zope to support testing log output in tests. Quoth flacoste: "There is zope.testing.loggingsupport.InstalledHandler which is best used from doctest. And there is also zope.testing.loghandler.Handler which is meant to be used with TestCase subclasses. Both of these work with the logging framework." We should no longer be locally define MockLogger classes and those currently in use should be replaced with the appropriate zope handler. Many places in our tests we locally define a MockLogger class. There exist two classes in Zope to support testing log output in tests. Quote flacoste: "There is zope.testing.loggingsupport.InstalledHandler which is best used from doctest. And there is also zope.testing.loghandler.Handler which is meant to be used with TestCase subclasses. Both of these work with the logging framework." We should no longer be locally defining MockLogger classes and those currently in use should be replaced with the appropriate zope handler.
2007-09-26 19:45:34 Francis J. Lacoste launchpad: importance Undecided Medium
2010-11-27 23:48:23 Robert Collins summary Replace MockLoggers in tests with zope utilities Replace MockLoggers in tests with zope handlers
2010-12-20 23:08:03 Tim Penhey description Many places in our tests we locally define a MockLogger class. There exist two classes in Zope to support testing log output in tests. Quote flacoste: "There is zope.testing.loggingsupport.InstalledHandler which is best used from doctest. And there is also zope.testing.loghandler.Handler which is meant to be used with TestCase subclasses. Both of these work with the logging framework." We should no longer be locally defining MockLogger classes and those currently in use should be replaced with the appropriate zope handler. Many places in our tests we locally define a MockLogger class. There exist two classes in Zope to support testing log output in tests. Quote flacoste: "There is zope.testing.loggingsupport.InstalledHandler which is best used from doctest. And there is also zope.testing.loghandler.Handler which is meant to be used with TestCase subclasses. Both of these work with the logging framework." We should no longer be locally defining MockLogger classes and those currently in use should be replaced with the appropriate zope handler. NOTE: MockLoggers have been removed and now we have FakeLoggers and subclasses in lp.services.log.logger.
2011-09-22 03:05:05 Robert Collins launchpad: importance Medium High
2011-12-19 09:33:54 Robert Collins summary Replace MockLoggers in tests with zope handlers Replace MockLoggers in tests with fixtures.FakeLogger