Launchpad itself

Nascent Upload code doesn't check properly for bad distroseries

Bug #117557 reported by Julian Edwards
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

Various parts of the nascent upload code references a distrorelease even though it may still be None because the upload specified a bad distrorelease. This causes the upload to be rejected for the wrong reason: a code exception instead of a bad distrorelease.

example: uploadpolicy.py, checkUpload(), the is_ppa call will do this as will the code at line 125 just below.

Julian Edwards (julian-edwards)
Changed in soyuz:
importance: Undecided → Medium
status: Unconfirmed → Rejected
status: Rejected → Confirmed
Curtis Hovey (sinzui)
tags: added: tech-debt
Julian Edwards (julian-edwards)
summary: - Nascent Upload code doesn't check properly for bad distrorelease
+ Nascent Upload code doesn't check properly for bad distroseries
visibility: private → public
Revision history for this message
Robert Collins (lifeless) wrote :

This should be oopsing now if its raising attributeerror, so critical.

Changed in launchpad:
importance: Medium → Critical
Revision history for this message
Julian Edwards (julian-edwards) wrote :

This won't raise an OOPS. It's not critical, please check before changing statuses.

Changed in launchpad:
importance: Critical → High
Revision history for this message
Robert Collins (lifeless) wrote :

So, my understanding then is that this is a confusing UI situation - we don't OOPS, we don't incorrectly accept, we correctly reject, but the message is horrible and confusing.

I'm dropping this to low as a result.

tags: added: confusing-ui
Changed in launchpad:
importance: High → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.