YUITest failures because quantal's webkit disagrees with lucids

[Curtis Hovey]

A test in test_choiceedit.html always fails when run under quantal, but is okay on lucid. The two distro series use different webkit version. The icons, according to css rules should be inline-block, but the widget and test require them to be inline. Quantal with the new webkit sees what the Lp site styles/class, but lucid is only seeing the widget's styles. The widget under test is directly manipulating element styles instead of applying classes, so the fix might be to update stop assuming it knows the site rules. The test should verify the presence of classes.

Failure in test lib/lp/app/javascript/choiceedit/tests/test_choiceedit.html
Traceback (most recent call last):
_StringException: Traceback (most recent call last):
  File "/home/curtis/Work/launchpad/devel/lib/lp/testing/__init__.py", line 1060, in checkResults
    self.assertEqual([], failures, '\n'.join(failures))
MismatchError: !=:
reference = []
actual = ['Failure in /home/curtis/Work/launchpad/devel/lib/lp/app/javascript/choiceedit/tests/test_choiceedit.html.nullable_choice_edit.test_action_icon: Add icon is not visible when it should be\nExpected: inline (string)\nActual: inline-block (string)']
: Failure in /home/curtis/Work/launchpad/devel/lib/lp/app/javascript/choiceedit/tests/test_choiceedit.html.nullable_choice_edit.test_action_icon: Add icon is not visible when it should be
Expected: inline (string)
Actual: inline-block (string)

[Curtis Hovey (sinzui)]

This issue may affect the Lp upgrade to precise which is using python wrapper of the new webkit.

[Colin Watson (cjwatson)]

I don't know when this was fixed exactly, but since we've been running on xenial for years and on precise for years before that, I guess it must have been fixed somewhere along the line.