Launchpad itself

package overrides functionality is inconsistently implemented

Bug #1073755 reported by Ian Booth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
William Grant

Bug Description

The functionality to determine the correct component override for source and binary publications is implemented slightly differently in a couple of places. There's adaptors defined in lp.soyuz.adapters.overrides.py and find_and_apply_overrides() defined in NascentUpload. The code really needs to be properly consolidated to use a common implementation.

Related branches

lp:~wgrant/launchpad/overrides-dicts
Colin Watson (community): Approve
Diff: 827 lines (+160/-216)
10 files modified
lib/lp/soyuz/adapters/overrides.py (+43/-68)
lib/lp/soyuz/adapters/tests/test_overrides.py (+91/-110)
lib/lp/soyuz/model/packagecopyjob.py (+5/-8)
lib/lp/soyuz/model/publishing.py (+5/-5)
lib/lp/soyuz/model/queue.py (+1/-2)
lib/lp/soyuz/scripts/packagecopier.py (+3/-3)
lib/lp/soyuz/scripts/tests/test_copypackage.py (+2/-3)
lib/lp/soyuz/tests/test_packagecopyjob.py (+8/-14)
lib/lp/soyuz/tests/test_packageupload.py (+1/-1)
lib/lp/testing/factory.py (+1/-2)
lp:~wgrant/launchpad/overrides-arch-indep
Colin Watson (community): Approve
Diff: 73 lines (+22/-10)
2 files modified
lib/lp/soyuz/adapters/overrides.py (+14/-7)
lib/lp/soyuz/adapters/tests/test_overrides.py (+8/-3)
lp:~wgrant/launchpad/overrides-include-versions
Celso Providelo (community): Approve
Diff: 229 lines (+50/-25)
2 files modified
lib/lp/soyuz/adapters/overrides.py (+33/-17)
lib/lp/soyuz/adapters/tests/test_overrides.py (+17/-8)
lp:~wgrant/launchpad/overrides-cross-archs
Celso Providelo (community): Approve
Diff: 307 lines (+139/-30)
5 files modified
lib/lp/soyuz/adapters/overrides.py (+42/-12)
lib/lp/soyuz/adapters/tests/test_overrides.py (+92/-12)
lib/lp/soyuz/model/packagecopyjob.py (+3/-4)
lib/lp/soyuz/model/publishing.py (+1/-1)
lib/lp/soyuz/scripts/packagecopier.py (+1/-1)
lp:~wgrant/launchpad/nu-overrides-adapters
Celso Providelo (community): Approve
Diff: 358 lines (+95/-175)
3 files modified
lib/lp/archiveuploader/nascentupload.py (+89/-165)
lib/lp/soyuz/doc/soyuz-set-of-uploads.txt (+2/-1)
lib/lp/soyuz/scripts/packagecopier.py (+4/-9)
lp:~wgrant/launchpad/overrides-init
Celso Providelo (community): Approve
Diff: 662 lines (+200/-100)
7 files modified
lib/lp/soyuz/adapters/overrides.py (+50/-38)
lib/lp/soyuz/adapters/tests/test_overrides.py (+140/-53)
lib/lp/soyuz/interfaces/archive.py (+1/-1)
lib/lp/soyuz/model/archive.py (+3/-1)
lib/lp/soyuz/model/packagecopyjob.py (+5/-4)
lib/lp/soyuz/model/publishing.py (+0/-1)
lib/lp/soyuz/scripts/packagecopier.py (+1/-2)
lp:~wgrant/launchpad/nu-overrides-refactor
Colin Watson (community): Approve
Diff: 524 lines (+156/-202)
4 files modified
lib/lp/archiveuploader/nascentupload.py (+137/-199)
lib/lp/soyuz/doc/archive.txt (+8/-0)
lib/lp/soyuz/interfaces/archive.py (+6/-3)
lib/lp/soyuz/model/archive.py (+5/-0)
lp:~wgrant/launchpad/overrides-copies
Celso Providelo (community): Approve
Diff: 417 lines (+77/-74)
3 files modified
lib/lp/soyuz/adapters/overrides.py (+29/-18)
lib/lp/soyuz/adapters/tests/test_overrides.py (+22/-21)
lib/lp/soyuz/model/packagecopyjob.py (+26/-35)
lp:~wgrant/launchpad/overrides-fallback
Colin Watson (community): Approve
Diff: 207 lines (+57/-52)
4 files modified
lib/lp/soyuz/adapters/overrides.py (+21/-35)
lib/lp/soyuz/adapters/tests/test_overrides.py (+22/-12)
lib/lp/soyuz/configure.zcml (+1/-1)
lib/lp/soyuz/model/archive.py (+13/-4)
lp:~wgrant/launchpad/overrides-actually
Celso Providelo (community): Approve
Diff: 628 lines (+394/-74)
7 files modified
lib/lp/soyuz/adapters/overrides.py (+30/-6)
lib/lp/soyuz/adapters/tests/test_overrides.py (+44/-23)
lib/lp/soyuz/configure.zcml (+3/-0)
lib/lp/soyuz/model/archive.py (+30/-5)
lib/lp/soyuz/model/packagecopyjob.py (+2/-8)
lib/lp/soyuz/scripts/packagecopier.py (+13/-32)
lib/lp/soyuz/tests/test_archive.py (+272/-0)
William Grant (wgrant)
tags: added: tech-debt
William Grant (wgrant)
tags: added: package-copies package-overrides
Changed in launchpad:
assignee: nobody → William Grant (wgrant)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17118 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17118) is part of this bug's fix.

tags: added: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17119 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17119) is part of this bug's fix.

William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17127 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17127) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17128 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17128) is part of this bug's fix.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17129 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17129) is part of this bug's fix.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17131 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17131) is part of this bug's fix.

William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17133 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17133) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17134 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17134) is part of this bug's fix.

William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17138 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17138>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.