{git-commit} doesn't work in a build recipe (0.3)

[Darxus]

This works:
# bzr-builder format 0.3 deb-version {debversion}+{revno}
These fail:
# bzr-builder format 0.3 deb-version {debversion}+{git-commit}
# bzr-builder format 0.3 deb-version {debversion}+{revdate}

Recipe: https://code.launchpad.net/~darxus/+recipe/wayland-daily
Building from: lp:~ted/wayland/master

Failures:
https://code.launchpad.net/~darxus/+archive/wayland-daily/+recipebuild/315684
bzr: ERROR: bzrlib.errors.BzrCommandError: deb-version not fully expanded: {debversion}+{git-commit}. Valid substitutions are: ['{time}', '{date}', '{revno:packaging}', '{revno}', '{svn-revno:packaging}', '{svn-revno}', '{git-commit:packaging}', '{git-commit}', '{latest-tag:packaging}', '{latest-tag}', '{debversion:packaging}', '{debversion}', '{debupstream-base:packaging}', '{debupstream-base}', '{debupstream:packaging}', '{debupstream}', '{revdate:packaging}', '{revdate}', '{revtime:packaging}', '{revtime}']

https://code.launchpad.net/~darxus/+archive/wayland-daily/+recipebuild/315657
bzr: ERROR: bzrlib.errors.BzrCommandError: deb-version not fully expanded: {debversion}+{revdate}. Valid substitutions are: ['{time}', '{date}', '{revno:packaging}', '{revno}', '{svn-revno:packaging}', '{svn-revno}', '{git-commit:packaging}', '{git-commit}', '{latest-tag:packaging}', '{latest-tag}', '{debversion:packaging}', '{debversion}', '{debupstream-base:packaging}', '{debupstream-base}', '{debupstream:packaging}', '{debupstream}', '{revdate:packaging}', '{revdate}', '{revtime:packaging}', '{revtime}']

https://code.launchpad.net/~darxus/+archive/wayland-daily/+recipebuild/315651
bzr: ERROR: bzrlib.errors.BzrCommandError: deb-version not fully expanded: {debversion}+{git-commit}. Valid substitutions are: ['{time}', '{date}', '{revno:packaging}', '{revno}', '{svn-revno:packaging}', '{svn-revno}', '{git-commit:packaging}', '{git-commit}', '{latest-tag:packaging}', '{latest-tag}', '{debversion:packaging}', '{debversion}', '{debupstream-base:packaging}', '{debupstream-base}', '{debupstream:packaging}', '{debupstream}', '{revdate:packaging}', '{revdate}', '{revtime:packaging}', '{revtime}']

And I just got "You have exceeded today's quota for ubuntu quantal.", which is incredibly frustrating.

[i30817 (i30817)]

Have this too... kinda strange the options are given for the upstream rev numbers if they don't work on the launchpad mirrors...

[i30817 (i30817)]

I had it for svn-revno instead though.

[i30817 (i30817)]

Welllllll.
{svn-revno}, {svn-revno:<branch id>} Replaced with the svn revision number of the revision that was built 0.4

{git-commit}, {git-commit:<branch id>} Replaced with the last 7 characters of the git commit that was built 0.4

So if we change 0.3 to 0.4 it might work (the recipe tut/wiki should be updated to set the example to 0.4 though)

[Darxus (darxus)]

Bah. Changed to:
# bzr-builder format 0.4 deb-version {debversion}+{date}+{git-commit}

Got:
bzr: ERROR: exceptions.AttributeError: 'cStringIO.StringI' object has no attribute 'split'

https://launchpadlibrarian.net/117938668/buildlog.txt.gz
https://launchpad.net/~darxus/+archive/wayland-daily/+recipebuild/316907

I acknowledge you said "might", but you really got my hopes up.

This thing sure can be frustrating to try to work with.

[Curtis Hovey (sinzui)]

The command is {git-commit:packaging}, not {git-commit} and it can only be used if you name one of the branches 'packaging'
such as :
# bzr-builder format 0.4 deb-version {debversion}+{date}+{git-commit:packaging}
lp:~ted/wayland/master
merge packaging lp:~darxus/+junk/wayland-packaging

[Darxus (darxus)]

Curtis: The error message and tutorial ( https://help.launchpad.net/Packaging/SourceBuilds/Recipes ) both say {git-commit} (without :packaging) should work. {git-commit:packaging} would give me the git commit of the packaging branch? That's not a git repo in this case, and not what I'm interested in being able to find the git repo of. I'd like people to be able to find out what upstream git commit the package was built from, as is listed as the Revision ID in the import details: https://bazaar.launchpad.net/~ted/wayland/master/revision/1077

[Curtis Hovey (sinzui)]

There are two issues in this bug
1. Bug #891880 about 0.4 commands are shown as valid option in 0.3 recipes
   {git-commit} is not a valid version on 0.3
and
2. bug #915505 about the buildd running an older version of debversion.
    which is the split error you see in one example.

Though issue 1 is fixed upstream, the buildd is running the old version. This issue will be fixed when the servers are upgraded, probably to Ubuntu 12.04.

[Colin Watson (cjwatson)]

Now that our virtual builders are running a trusty base system with bzr-builder 0.7.3, this should all work much better: you should be able to bump your recipe version to 0.4 and use {git-commit}. Please let us know if this doesn't work, for instance by reopening this bug.