choice.js does not require array-extras with YUI 3.5
Bug #1052618 reported by
Aaron Bentley
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Colin Watson |
Bug Description
In YUI 3.3, Y.Array.forEach is an alias for each activated by the array-extras package. In 3.5, it's part of the core and prefers to use the Ecmascript 5 functionality. choice.js should stop requiring array-extras after we switch to 3.5
Related branches
lp:~cjwatson/launchpad/drop-yui-array-extras
- William Grant (community): Approve (code)
-
Diff: 27 lines (+2/-7)2 files modifiedlib/lp/app/javascript/choice.js (+1/-6)
lib/lp/app/javascript/expander.js (+1/-1)
tags: | added: javascript tech-debt |
Changed in launchpad: | |
assignee: | nobody → Colin Watson (cjwatson) |
status: | Triaged → In Progress |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r17347 (http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 17347) by a commit, but not testable.