Changing a team owner assumes that it's the previous owner doing it

Bug #1049487 reported by William Grant
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Steve Kowalik

Bug Description

From TeamReassignmentView._afterOwnerChange():

        if newOwner not in team.inactivemembers:
            team.addMember(
                newOwner, reviewer=oldOwner,
                status=TeamMembershipStatus.ADMIN, force_team_add=True)
        if oldOwner not in team.inactivemembers:
            team.addMember(
                oldOwner, reviewer=oldOwner,
                status=TeamMembershipStatus.ADMIN, force_team_add=True)

But a Launchpad admin, or a member of the old owning team, can also perform the action. The reviewer should be the current user, not the old owner.

Related branches

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 1049487] [NEW] Changing a team owner assumes that it's the previous owner doing it

This may be a dupe; I remember whinging about it a couple months back.

Curtis Hovey (sinzui)
tags: added: email
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
Changed in launchpad:
assignee: nobody → Steve Kowalik (stevenk)
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
Revision history for this message
Curtis Hovey (sinzui) wrote : Re: [Bug 1049487] Re: Changing a team owner assumes that it's the previous owner doing it

\o/

--
Curtis Hovey
Canonical Cloud Engineering
http://launchpad.net/~sinzui

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.