Resources returned by getSharedArtifacts not adapted to resource object type
Bug #1049374 reported by
Cody A.W. Somerville
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Ian Booth |
Bug Description
Branches and bugs returned by getSharedArtifacts are not adapted corresponding to resource object type. Instead they are just plain dictionaries.
Related branches
lp:~wallyworld/launchpad/getSharedArtifacts-data-1049374
- Curtis Hovey (community): Approve (code)
-
Diff: 266 lines (+113/-51)3 files modifiedlib/lp/registry/interfaces/sharingservice.py (+34/-14)
lib/lp/registry/services/sharingservice.py (+18/-3)
lib/lp/registry/services/tests/test_sharingservice.py (+61/-34)
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Ian Booth (wallyworld) |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think this relates to bug 1028819 which does not want to export PillarName because it is not a useful class. The method we are working with returns an intermediate object that no callsite wants. Launchpad or its restful adapters need to convert the two collections to their respective times. The easier bug very annoy way to solve this is to introduce a type that is just a pointer to the real object that will require EVERY callsite to make an additional call back to lp to get the proper data. We really do not want to do this.