Launchpad itself

UnusedSharingPolicyPruner doesn't preserve permitted access policies

Bug #1043319 reported by William Grant
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
William Grant

Bug Description

UnusedSharingPolicyPruner is meant to keep any access policies that are in use by artifacts, or allowed by the project sharing policy. The first bit works fine, but the sharing policy bit is buggy: it calculates the set difference between the extant access policies and the allowed types, but those are different types of object. It needs to instead find the access policies that have types not in the allowed set.

Related branches

lp:~wgrant/launchpad/bug-1043319
Curtis Hovey (community): Approve (code)
Diff: 122 lines (+40/-20)
2 files modified
lib/lp/scripts/garbo.py (+9/-9)
lib/lp/scripts/tests/test_garbo.py (+31/-11)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r15877 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15877>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Steve Kowalik (stevenk)
Changed in launchpad:
status: Fix Committed → Fix Released
Revision history for this message
William Grant (wgrant) wrote :

http://pastebin.ubuntu.com/1176926/ has been run on production to recreate the missing APs.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.